Re: [rfa] create testsuite/gdb.cp directory

Re: [rfa] create testsuite/gdb.cp directory

[Michael Elizabeth Chastain]

ac> There should be only one C++ testsuite directory: gdb.c++ XOR gdb.cp. 

Word.

Okay, I will revise my formal proposal to do what everybody wants:

  (1) create testsuite/gdb.cp
  (2) "cvs add" all the files from gdb.c++/* to gdb/cp
  (3) "cvs remove" all the files from gdb.c++
  (4) All this in gdb HEAD, no action in gdb gdb_6_0-branch

I am open to changing (4) and doing it in the branch as well
if David and Andrew want that (and I always care about Daniel's
opinion as well).  It is a .0 release after all.  But if nobody
says anything then I'm not messing with the branch.

I'm resetting the 1-week clock.  Opinions welcomed, even: "Hey! 
I need more than one week to respond to this, you insensitive clod!"

Michael C

P. S. For once, Staten Island doesn't suck hind tit!
      We got our power back before any other borough!

Re: [rfa] create testsuite/gdb.cp directory

[David Carlton]

On Fri, 15 Aug 2003 11:34:31 -0400, Michael Elizabeth Chastain <mec@shout.net> said:

> Okay, I will revise my formal proposal to do what everybody wants:

>   (1) create testsuite/gdb.cp
>   (2) "cvs add" all the files from gdb.c++/* to gdb/cp
>   (3) "cvs remove" all the files from gdb.c++

Great!

>   (4) All this in gdb HEAD, no action in gdb gdb_6_0-branch

> I am open to changing (4) and doing it in the branch as well if
> David and Andrew want that (and I always care about Daniel's opinion
> as well).

I guess I have a slight preference for doing it on the branch as well.
The main difference seems to be that, if we don't, it will make future
mainline/6.0 comparisons harder but 6.0/5.3 comparisons easier,
whereas, if we do, it will make mainline/6.0 comparisons easier but
6.0/5.3 comparisons harder.  Given that 6.0 is about to be released
(right?), 6.0/5.3 comparisons should soon become mostly irrelevant.
Also, it will make it easier to apply testsuite patches to both the
mainline and branch, when appropriate.

Having said that, I don't really care much at all one way or another.

David Carlton
carlton@kealia.com

Re: [rfa] create testsuite/gdb.cp directory

[Andrew Cagney]

> dc> Why not move all the existing scripts to the new directory?  That's
> dc> what I'd prefer.
> 
> I'm okay with that.  But it would kill the cvs history of the tests,
> and it would hurt people doing 'diff' on test runs from before and
> after the change (such as gdb 6 to HEAD, after gdb 6 is released).
> It wouldn't hurt my test bed because I use a 1000-line Perl script,
> not diff, so I can adapt to test name changes.
> 
> So I'll subdivide my proposal:
> 
>   (1) Create new directory gdb.cp
>   (2) Move all existing tests from gdb.c++ to gdb.cp
> 
> I have no objection to (2).  But if anyone objects to (2),
> then I still want to do (1), with or without (2).

There should be only one C++ testsuite directory: gdb.c++ XOR gdb.cp. 
Otherwize general confusion will result and, no matter how good 
everyones intent, new gdb.c++/* tests will eventually be added.

I'd not put much weight on CVS stupidity.  Limitations of the configure 
tool should not be used as an excuse for failing to fix a problem :-)

enjoy,
Andrew

Re: [rfa] create testsuite/gdb.cp directory

[Michael Elizabeth Chastain]

dc> Why not move all the existing scripts to the new directory?  That's
dc> what I'd prefer.

I'm okay with that.  But it would kill the cvs history of the tests,
and it would hurt people doing 'diff' on test runs from before and
after the change (such as gdb 6 to HEAD, after gdb 6 is released).
It wouldn't hurt my test bed because I use a 1000-line Perl script,
not diff, so I can adapt to test name changes.

So I'll subdivide my proposal:

  (1) Create new directory gdb.cp
  (2) Move all existing tests from gdb.c++ to gdb.cp

I have no objection to (2).  But if anyone objects to (2),
then I still want to do (1), with or without (2).

Michael C

Re: [rfa] create testsuite/gdb.cp directory

[Daniel Jacobowitz]

On Thu, Aug 14, 2003 at 02:10:21PM -0400, Michael Elizabeth Chastain wrote:
> This is a formal proposal to create a new directory, testsuite/gdb.cp,
> for c++ tests.  This proposal is for HEAD only, not gdb_6_0-branch.
> 
> The issue is that "gdb.c++" contains characters which are not permitted
> on MS-DOS filenames.  So *every* file in testsuite/gdb.c++ must have an
> entry in config/djgpp/fnchange.lst.  I would like to get away from that
> requirement and use plain directory names that just work everywhere.
> 
> I propose to use testsuite/gdb.cp for new C++ test scripts only.
> Existing scripts would remain in gdb.c++.
> 
> 'cp' is the same name that other C++ files in gdb have,
> such as cp-abi.c, cp-namespace.c, and cp-support.c.
> Also libiberty/cp-demangle.c.

I would prefer to move all existing tests.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [rfa] create testsuite/gdb.cp directory

[David Carlton]

On Thu, 14 Aug 2003 14:10:21 -0400, Michael Elizabeth Chastain <mec@shout.net> said:

> I propose to use testsuite/gdb.cp for new C++ test scripts only.
> Existing scripts would remain in gdb.c++.

Why not move all the existing scripts to the new directory?  That's
what I'd prefer.

David Carlton
carlton@kealia.com

[rfa] create testsuite/gdb.cp directory

[Michael Elizabeth Chastain]

This is a formal proposal to create a new directory, testsuite/gdb.cp,
for c++ tests.  This proposal is for HEAD only, not gdb_6_0-branch.

The issue is that "gdb.c++" contains characters which are not permitted
on MS-DOS filenames.  So *every* file in testsuite/gdb.c++ must have an
entry in config/djgpp/fnchange.lst.  I would like to get away from that
requirement and use plain directory names that just work everywhere.

I propose to use testsuite/gdb.cp for new C++ test scripts only.
Existing scripts would remain in gdb.c++.

'cp' is the same name that other C++ files in gdb have,
such as cp-abi.c, cp-namespace.c, and cp-support.c.
Also libiberty/cp-demangle.c.

I am proposing this because I want to add a test script for
pr gdb/186, which has been open for two years and is still broken
with gdb HEAD.  I'd like to start adding new test scripts to
the new directory, so I'm coming here to create the new directory.

'cvs add' with a directory name is irreversible (with cvs commands
at least) so I am making a formal application to do this.

Okay to create new directory gdb/testsuite/gdb.cp in HEAD ?

Michael C