[commit, 6.0] Fix fnchange ARI problems

[commit, 6.0] Fix fnchange ARI problems

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 91 bytes --]

Just FYI.

Mark, can something be done about the three externs in amd64fbsd-nat.c?

Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1552 bytes --]

2003-08-02  Andrew Cagney  <cagney@redhat.com>

	* config/djgpp/fnchange.lst: Fix up testsuite/gdb.c++/annota3.cc,
	gdb/testsuite/gdb.c++/annota3.exp, amd64fbsd-tdep.c and
	amd64fbsd-nat.c.

Index: config/djgpp/fnchange.lst
===================================================================
RCS file: /cvs/src/src/gdb/config/djgpp/fnchange.lst,v
retrieving revision 1.51.2.2
diff -u -r1.51.2.2 fnchange.lst
--- config/djgpp/fnchange.lst	27 Jun 2003 02:15:59 -0000	1.51.2.2
+++ config/djgpp/fnchange.lst	3 Aug 2003 02:20:04 -0000
@@ -70,6 +70,8 @@
 @V@/gdb/ChangeLog-2002 @V@/gdb/ChangeLog.002
 @V@/gdb/ChangeLog-3.x @V@/gdb/ChangeLog.3-x
 @V@/gdb/ada-exp.tab.c @V@/gdb/ada-exp_tab.c
+@V@/gdb/amd64fbsd-tdep.c @V@/gdb/x86fb-tdep.c
+@V@/gdb/amd64fbsd-nat.c @V@/gdb/x86fb-nat.c
 @V@/gdb/alphabsd-nat.c @V@/gdb/alphb-nat.c
 @V@/gdb/alphabsd-tdep.c @V@/gdb/alphb-tdep.c
 @V@/gdb/alphanbsd-nat.c @V@/gdb/alphnb-nat.c
@@ -202,6 +204,8 @@
 @V@/gdb/testsuite/gdb.c++/ambiguous.exp @V@/gdb/testsuite/gdb.cxx/ambiguous.exp
 @V@/gdb/testsuite/gdb.c++/annota2.cc @V@/gdb/testsuite/gdb.cxx/annota2.cc
 @V@/gdb/testsuite/gdb.c++/annota2.exp @V@/gdb/testsuite/gdb.cxx/annota2.exp
+@V@/gdb/testsuite/gdb.c++/annota3.cc @V@/gdb/testsuite/gdb.cxx/annota3.cc
+@V@/gdb/testsuite/gdb.c++/annota3.exp @V@/gdb/testsuite/gdb.cxx/annota3.exp
 @V@/gdb/testsuite/gdb.c++/anon-union.cc @V@/gdb/testsuite/gdb.cxx/anon-union.cc
 @V@/gdb/testsuite/gdb.c++/anon-union.exp @V@/gdb/testsuite/gdb.cxx/anon-union.exp
 @V@/gdb/testsuite/gdb.c++/casts.cc @V@/gdb/testsuite/gdb.cxx/casts.cc

Re: [commit, 6.0] Fix fnchange ARI problems

[Eli Zaretskii]

> Date: Sat, 02 Aug 2003 22:24:32 -0400
> From: Andrew Cagney <ac131313@redhat.com>
> 
> Just FYI.

Thanks.

However, I think these 2 remappings are gross:

> +@V@/gdb/amd64fbsd-tdep.c @V@/gdb/x86fb-tdep.c
> +@V@/gdb/amd64fbsd-nat.c @V@/gdb/x86fb-nat.c

Up until now, I was trying to preserve at least the few first letters
of the original name, so that a reasonable person could have a chance
of deducting the original name from the butchered one.  The above
goes a long way toward breaking that.

So I suggest the following instead:

> +@V@/gdb/amd64fbsd-tdep.c @V@/gdb/amd64f-tdep.c
> +@V@/gdb/amd64fbsd-nat.c @V@/gdb/amd64f-nat.c

Or are these already taken?

Re: [commit, 6.0] Fix fnchange ARI problems

[Andrew Cagney]

> Date: Sat, 02 Aug 2003 22:24:32 -0400
>> From: Andrew Cagney <ac131313@redhat.com>
>> 
>> Just FYI.
> 
> 
> Thanks.
> 
> However, I think these 2 remappings are gross:
> 
> 
>> +@V@/gdb/amd64fbsd-tdep.c @V@/gdb/x86fb-tdep.c
>> +@V@/gdb/amd64fbsd-nat.c @V@/gdb/x86fb-nat.c
> 
> 
> Up until now, I was trying to preserve at least the few first letters
> of the original name, so that a reasonable person could have a chance
> of deducting the original name from the butchered one.  The above
> goes a long way toward breaking that.
> 
> So I suggest the following instead:
> 
> 
>> +@V@/gdb/amd64fbsd-tdep.c @V@/gdb/amd64f-tdep.c
>> +@V@/gdb/amd64fbsd-nat.c @V@/gdb/amd64f-nat.c

I'll change it.

Mark, should the original files be called x86-64-*?

Andrew

Re: [commit, 6.0] Fix fnchange ARI problems

[Daniel Jacobowitz]

On Mon, Aug 04, 2003 at 08:58:11AM -0400, Andrew Cagney wrote:
> >Date: Sat, 02 Aug 2003 22:24:32 -0400
> >>From: Andrew Cagney <ac131313@redhat.com>
> >>
> >>Just FYI.
> >
> >
> >Thanks.
> >
> >However, I think these 2 remappings are gross:
> >
> >
> >>+@V@/gdb/amd64fbsd-tdep.c @V@/gdb/x86fb-tdep.c
> >>+@V@/gdb/amd64fbsd-nat.c @V@/gdb/x86fb-nat.c
> >
> >
> >Up until now, I was trying to preserve at least the few first letters
> >of the original name, so that a reasonable person could have a chance
> >of deducting the original name from the butchered one.  The above
> >goes a long way toward breaking that.
> >
> >So I suggest the following instead:
> >
> >
> >>+@V@/gdb/amd64fbsd-tdep.c @V@/gdb/amd64f-tdep.c
> >>+@V@/gdb/amd64fbsd-nat.c @V@/gdb/amd64f-nat.c
> 
> I'll change it.
> 
> Mark, should the original files be called x86-64-*?

No, he mentioned in his original posting that the FreeBSD port (like
the architecture, now) is called amd64.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [commit, 6.0] Fix fnchange ARI problems

[Andrew Cagney]

>> Mark, should the original files be called x86-64-*?
> 
> 
> No, he mentioned in his original posting that the FreeBSD port (like
> the architecture, now) is called amd64.

All the files for that architecture should be called x86-64-* xor amd64-*.

Andrew

Re: [commit, 6.0] Fix fnchange ARI problems

[Andrew Cagney]

[please don't edit me out of To: or Cc: lines - I'll otherwize won't see 
it at present :-(]

>> +  static long dummy[4] = { 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff };
>> +  static long mxcsr = 0x1f80;
>> +  int reg;
>> +
>> +  for (reg = 0; reg < tdep->num_xmm_regs; reg++)
>> +    supply_register (XMM0_REGNUM + reg, (char *) dummy);
>> +  if (tdep->num_xmm_regs > 0)
>> +    supply_register (MXCSR_REGNUM, (char *) &mxcsr);
>> +}
> 
> Won't work on a big-endian LP64 host.  You've filled them with 0
> instead of -1 if I remember my C promotions right.

The function was cut/paste from the i386-linux-nat.c, so not me.  I'd 
better fix it's portability problems though.

> Otherwise, I have some code to do the same thing, and it looks exactly
> the same, which is a good sign :)  I'm too backlogged waiting for
> review of things I've already posted to realistically flush the rest of
> my queue, so I'm glad to see someone else save me the trouble.

Exactly how old's the patch?  You should just push these out.

Andrew

Re: [commit, 6.0] Fix fnchange ARI problems

[Daniel Jacobowitz]

On Mon, Aug 04, 2003 at 12:54:52PM -0400, Andrew Cagney wrote:
> [please don't edit me out of To: or Cc: lines - I'll otherwize won't see 
> it at present :-(]
> 
> >>+  static long dummy[4] = { 0xffffffff, 0xffffffff, 0xffffffff, 
> >>0xffffffff };
> >>+  static long mxcsr = 0x1f80;
> >>+  int reg;
> >>+
> >>+  for (reg = 0; reg < tdep->num_xmm_regs; reg++)
> >>+    supply_register (XMM0_REGNUM + reg, (char *) dummy);
> >>+  if (tdep->num_xmm_regs > 0)
> >>+    supply_register (MXCSR_REGNUM, (char *) &mxcsr);
> >>+}
> >
> >Won't work on a big-endian LP64 host.  You've filled them with 0
> >instead of -1 if I remember my C promotions right.
> 
> The function was cut/paste from the i386-linux-nat.c, so not me.  I'd 
> better fix it's portability problems though.

Right, not accusing.  But this is part of moving the code from -nat to
-tdep.  To be fair, I noticed it when reading your patch, but mine has
the same bug :)

> >Otherwise, I have some code to do the same thing, and it looks exactly
> >the same, which is a good sign :)  I'm too backlogged waiting for
> >review of things I've already posted to realistically flush the rest of
> >my queue, so I'm glad to see someone else save me the trouble.
> 
> Exactly how old's the patch?  You should just push these out.

Sending dozens of patches to the list has, historically, not done the
slightest bit of good.  Lately, sending single patches and repeated
reminders hasn't either.  I'm too frustrated to add another patch to
the list I have to ping every month.

When my outstanding patches are approved or at least responded to, then
I will send more.

I don't suppose you have any plans to framify MIPS?  One of my
least-ready-for-submission patches adds signal handler unwinding for
mips-linux; it's hideous, and with the new frame code it would be much
cleaner.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: [commit, 6.0] Fix fnchange ARI problems

[Mark Kettenis]

   Date: Sat, 02 Aug 2003 22:24:32 -0400
   From: Andrew Cagney <ac131313@redhat.com>

   Mark, can something be done about the three externs in amd64fbsd-nat.c?

Sure!  I fixed those earlier today :-).

Considering your concerns about amd64 vs. x86-64 in the naming of the
files: my main motivation for not using x86-64 is that it's a PITA to
type the latter.  I'm even considering renaming the file that were
already present, just to make my life easier.  I won't do this without
discussing it with Michal and Andreas though.

Mark

Re: [commit, 6.0] Fix fnchange ARI problems

[Andrew Cagney]

>    Date: Sat, 02 Aug 2003 22:24:32 -0400
>    From: Andrew Cagney <ac131313@redhat.com>
> 
>    Mark, can something be done about the three externs in amd64fbsd-nat.c?
> 
> Sure!  I fixed those earlier today :-).
> 
> Considering your concerns about amd64 vs. x86-64 in the naming of the
> files: my main motivation for not using x86-64 is that it's a PITA to
> type the latter.  I'm even considering renaming the file that were
> already present, just to make my life easier.  I won't do this without
> discussing it with Michal and Andreas though.

True.  On the other hand, having to and remembering to grep for both 
amd64 and x86_84 in x86-64* and amd64* is also a pain.  The combined 
projects might want think about a jumbo re-name.

Andrew

Re: [commit, 6.0] Fix fnchange ARI problems

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 135 bytes --]

Since everyone objected, I've changed things so that the amd64 files get 
contracted to a64 :-)

committed to 6.0 and mainline,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 979 bytes --]

2003-09-14  Andrew Cagney  <cagney@redhat.com>

	* config/djgpp/fnchange.lst: Rename "amd64fbsd-tdep.c" and
	"amd64fbsd-nat.c" to "a64fb-tdep.c" and "a64fb-nat.c".

Index: config/djgpp/fnchange.lst
===================================================================
RCS file: /cvs/src/src/gdb/config/djgpp/fnchange.lst,v
retrieving revision 1.51.2.5
diff -u -r1.51.2.5 fnchange.lst
--- config/djgpp/fnchange.lst	28 Aug 2003 04:08:43 -0000	1.51.2.5
+++ config/djgpp/fnchange.lst	14 Sep 2003 21:07:43 -0000
@@ -70,8 +70,8 @@
 @V@/gdb/ChangeLog-2002 @V@/gdb/ChangeLog.002
 @V@/gdb/ChangeLog-3.x @V@/gdb/ChangeLog.3-x
 @V@/gdb/ada-exp.tab.c @V@/gdb/ada-exp_tab.c
-@V@/gdb/amd64fbsd-tdep.c @V@/gdb/x86fb-tdep.c
-@V@/gdb/amd64fbsd-nat.c @V@/gdb/x86fb-nat.c
+@V@/gdb/amd64fbsd-tdep.c @V@/gdb/a64fb-tdep.c
+@V@/gdb/amd64fbsd-nat.c @V@/gdb/a64fb-nat.c
 @V@/gdb/alphabsd-nat.c @V@/gdb/alphb-nat.c
 @V@/gdb/alphabsd-tdep.c @V@/gdb/alphb-tdep.c
 @V@/gdb/alphanbsd-nat.c @V@/gdb/alphnb-nat.c