Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit, 6.0] Fix fnchange ARI problems
Date: Mon, 04 Aug 2003 16:55:00 -0000	[thread overview]
Message-ID: <3F2E8FDC.9060106@redhat.com> (raw)
In-Reply-To: <un0ers2x8.fsf@elta.co.il>

[please don't edit me out of To: or Cc: lines - I'll otherwize won't see 
it at present :-(]

>> +  static long dummy[4] = { 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff };
>> +  static long mxcsr = 0x1f80;
>> +  int reg;
>> +
>> +  for (reg = 0; reg < tdep->num_xmm_regs; reg++)
>> +    supply_register (XMM0_REGNUM + reg, (char *) dummy);
>> +  if (tdep->num_xmm_regs > 0)
>> +    supply_register (MXCSR_REGNUM, (char *) &mxcsr);
>> +}
> 
> Won't work on a big-endian LP64 host.  You've filled them with 0
> instead of -1 if I remember my C promotions right.

The function was cut/paste from the i386-linux-nat.c, so not me.  I'd 
better fix it's portability problems though.

> Otherwise, I have some code to do the same thing, and it looks exactly
> the same, which is a good sign :)  I'm too backlogged waiting for
> review of things I've already posted to realistically flush the rest of
> my queue, so I'm glad to see someone else save me the trouble.

Exactly how old's the patch?  You should just push these out.

Andrew



  parent reply	other threads:[~2003-08-04 16:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-03  2:25 Andrew Cagney
2003-08-03  6:54 ` Eli Zaretskii
2003-08-04 12:58   ` Andrew Cagney
2003-08-04 14:09     ` Daniel Jacobowitz
2003-08-07  4:11       ` Andrew Cagney
2003-08-04 16:55   ` Andrew Cagney [this message]
2003-08-04 16:59     ` Daniel Jacobowitz
2003-08-10 23:09 ` Mark Kettenis
2003-08-11  3:18   ` Andrew Cagney
2003-09-14 21:11 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3F2E8FDC.9060106@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox