Re: [commit, 6.0] Fix fnchange ARI problems

Andrew Cagney
2003-08-04T16:55:15Z

[please don't edit me out of To: or Cc: lines - I'll otherwize won't see
it at present :-(]

>> + static long dummy[4] = { 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff };
>> + static long mxcsr = 0x1f80;
>> + int reg;
>> +
>> + for (reg = 0; reg < tdep->num_xmm_regs; reg++)
>> + supply_register (XMM0_REGNUM + reg, (char *) dummy);
>> + if (tdep->num_xmm_regs > 0)
>> + supply_register (MXCSR_REGNUM, (char *) &mxcsr);
>> +}
>
> Won't work on a big-endian LP64 host. You've filled them with 0
> instead of -1 if I remember my C promotions right.

The function was cut/paste from the i386-linux-nat.c, so not me. I'd
better fix it's portability problems though.

> Otherwise, I have some code to do the same thing, and it looks exactly
> the same, which is a good sign :) I'm too backlogged waiting for
> review of things I've already posted to realistically flush the rest of
> my queue, so I'm glad to see someone else save me the trouble.

Exactly how old's the patch? You should just push these out.

Andrew