From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31723 invoked by alias); 4 Aug 2003 16:55:15 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31698 invoked from network); 4 Aug 2003 16:55:05 -0000 Received: from unknown (HELO localhost.redhat.com) (24.157.166.107) by sources.redhat.com with SMTP; 4 Aug 2003 16:55:05 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 4DC712B7F; Mon, 4 Aug 2003 12:54:52 -0400 (EDT) Message-ID: <3F2E8FDC.9060106@redhat.com> Date: Mon, 04 Aug 2003 16:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.2) Gecko/20030223 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: [commit, 6.0] Fix fnchange ARI problems References: <3F2C7260.7080500@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2003-08/txt/msg00038.txt.bz2 [please don't edit me out of To: or Cc: lines - I'll otherwize won't see it at present :-(] >> + static long dummy[4] = { 0xffffffff, 0xffffffff, 0xffffffff, 0xffffffff }; >> + static long mxcsr = 0x1f80; >> + int reg; >> + >> + for (reg = 0; reg < tdep->num_xmm_regs; reg++) >> + supply_register (XMM0_REGNUM + reg, (char *) dummy); >> + if (tdep->num_xmm_regs > 0) >> + supply_register (MXCSR_REGNUM, (char *) &mxcsr); >> +} > > Won't work on a big-endian LP64 host. You've filled them with 0 > instead of -1 if I remember my C promotions right. The function was cut/paste from the i386-linux-nat.c, so not me. I'd better fix it's portability problems though. > Otherwise, I have some code to do the same thing, and it looks exactly > the same, which is a good sign :) I'm too backlogged waiting for > review of things I've already posted to realistically flush the rest of > my queue, so I'm glad to see someone else save me the trouble. Exactly how old's the patch? You should just push these out. Andrew