Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Kei Sakamoto <sakamoto.kei@renesas.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error
Date: Tue, 05 Aug 2003 18:02:00 -0000	[thread overview]
Message-ID: <20030805180235.GA30002@nevyn.them.org> (raw)
In-Reply-To: <028801c35a51$47db96d0$5169910a@KEI>

On Mon, Aug 04, 2003 at 03:26:03PM +0900, Kei Sakamoto wrote:
> Thank you, everyone. Now m32r is back! :-)
> 
> The attached fixes compile errors of asm-source.exp for m32r-elf.
> There are several missing symbols.
> 
> It also replaces ld24 instruction with seth/add3 instruction.
> ld24 can handle only 24bit address, so ld24 fails to set sp when
> _stack is located at a large address.
> 
> Kei Sakamoto
> 
> ===
> 
> 2003-08-04    Kei Sakamoto  <sakamoto.kei@renesas.com>
> 
> * gdb.asm/m32r.inc : Add several missing symbols. Replace ld24
>                      with seth/add3.

Two minor things:
  - You accidentally sent a reversed diff.
  - ChangeLog formatting.  It should be:

2003-08-04  Kei Sakamoto  <sakamoto.kei@renesas.com>

	* gdb.asm/m32r.inc: Add several missing symbols. Replace ld24
	with seth/add3.

One less minor thing: no other port needs to declare symbols.  It looks
like part of libc is being dragged in somehow on m32r; could you
explain why the symbols are necessary?

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-08-05 18:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-04  6:22 Kei Sakamoto
2003-08-05 18:02 ` Daniel Jacobowitz [this message]
2003-08-06  1:45   ` Kei Sakamoto
2003-08-06  6:08     ` Doug Evans
2003-08-06 13:04     ` Daniel Jacobowitz
2003-08-07  2:20       ` Kei Sakamoto
2003-08-07  4:06         ` Daniel Jacobowitz
2003-08-07  4:17   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030805180235.GA30002@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=sakamoto.kei@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox