Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Kei Sakamoto" <sakamoto.kei@renesas.com>
To: "Daniel Jacobowitz" <drow@mvista.com>
Cc: <gdb-patches@sources.redhat.com>
Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error
Date: Thu, 07 Aug 2003 02:20:00 -0000	[thread overview]
Message-ID: <00bb01c35c8a$b0142ba0$5169910a@KEI> (raw)
In-Reply-To: <20030806130352.GA25689@nevyn.them.org>

[-- Attachment #1: Type: text/plain, Size: 893 bytes --]

> -nostartfiles should prevent the inclusion of crt* but not of libgloss;
> libgloss is a matter for -nostdlib, which we _don't_ use.  I see that
> in the m32r GCC port, -lgloss is in ENDFILE_CPU_SPEC, which is unlike
> any other port.
> 
> I don't want to mess with that right now, but does adding -lgloss to
> ${link-flags} in asm-source.exp fix the problem?

It worked. I removed the declarations of symbols from the patch.

By the way, I noticed another bug in m32r.inc. In m32r.inc, there is
a sequential nop after bl instruction, which is illegal. M32r simulator
doesn't care about it, but real m32r chips cause exceptions.
The attached new patch  fixes this problem too.

Kei

===

2003-08-07    Kei Sakamoto  <sakamoto.kei@renesas.com>

* gdb.asm/asm-source.exp : Add -lgloss to link-flags.
* gdb.asm/m32r.inc : Remove an illegal nop after bl instruction.
Replace ld24 with seth/add3.

[-- Attachment #2: diffs --]
[-- Type: application/octet-stream, Size: 1022 bytes --]

diff -Naur src.orig/gdb/testsuite/gdb.asm/asm-source.exp src/gdb/testsuite/gdb.asm/asm-source.exp
--- src.orig/gdb/testsuite/gdb.asm/asm-source.exp	2003-07-16 02:23:32.000000000 +0900
+++ src/gdb/testsuite/gdb.asm/asm-source.exp	2003-08-07 10:11:20.000000000 +0900
@@ -69,6 +69,7 @@
     }
     "m32r*-*" {
         set asm-arch m32r
+        set link-flags "-Wl,--whole-archive -lgloss -Wl,--no-whole-archive"
     }
     "m6811-*-*" {
         set asm-arch m68hc11
diff -Naur src.orig/gdb/testsuite/gdb.asm/m32r.inc src/gdb/testsuite/gdb.asm/m32r.inc
--- src.orig/gdb/testsuite/gdb.asm/m32r.inc	2001-11-22 10:13:10.000000000 +0900
+++ src/gdb/testsuite/gdb.asm/m32r.inc	2003-08-07 11:05:13.000000000 +0900
@@ -11,7 +11,7 @@
 	.endm
 
 	.macro gdbasm_call subr
-	bl	\subr -> nop
+	bl	\subr
 	.endm
 
 	.macro gdbasm_several_nops
@@ -30,6 +30,7 @@
 
 	comment "crt0 startup"
 	.macro gdbasm_startup
-	ld24 sp,_stack
+	seth sp, #shigh(_stack)
+	add3 sp, sp, #low(_stack)
 	ldi fp,#0
 	.endm

  reply	other threads:[~2003-08-07  2:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-04  6:22 Kei Sakamoto
2003-08-05 18:02 ` Daniel Jacobowitz
2003-08-06  1:45   ` Kei Sakamoto
2003-08-06  6:08     ` Doug Evans
2003-08-06 13:04     ` Daniel Jacobowitz
2003-08-07  2:20       ` Kei Sakamoto [this message]
2003-08-07  4:06         ` Daniel Jacobowitz
2003-08-07  4:17   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00bb01c35c8a$b0142ba0$5169910a@KEI' \
    --to=sakamoto.kei@renesas.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox