From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28106 invoked by alias); 7 Aug 2003 02:20:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28098 invoked from network); 7 Aug 2003 02:20:41 -0000 Received: from unknown (HELO mail02.idc.renesas.com) (202.234.163.13) by sources.redhat.com with SMTP; 7 Aug 2003 02:20:41 -0000 Received: from mail02.idc.renesas.com ([127.0.0.1]) by mail02.idc.renesas.com with ESMTP id h772Kc1Q003645 for ; Thu, 7 Aug 2003 11:20:39 +0900 (JST) Received: from guardian01.idc.renesas.com ([172.20.8.132]) by mail02.idc.renesas.com with ESMTP id h772KbUO003642; Thu, 7 Aug 2003 11:20:38 +0900 (JST) Received: (from root@localhost) by guardian01.idc.renesas.com with id h772KaaX003740; Thu, 7 Aug 2003 11:20:36 +0900 (JST) Received: from unknown [172.20.8.69] by guardian01.idc.renesas.com with SMTP id MAA03739 ; Thu, 7 Aug 2003 11:20:36 +0900 Received: from mta02.idc.renesas.com (localhost [127.0.0.1]) by mta02.idc.renesas.com with ESMTP id h772KbCd018063; Thu, 7 Aug 2003 11:20:37 +0900 (JST) Received: from rnsmtp01.hoku_r.renesas.com ([10.145.246.51]) by mta02.idc.renesas.com with ESMTP id h772Ka84018060; Thu, 7 Aug 2003 11:20:36 +0900 (JST) Received: from mrkaisv.hoku.renesas.com ([10.145.105.245]) by rnsmtp01.hoku_r.renesas.com (8.9.3/3.7W) with ESMTP id LAA26889; Thu, 7 Aug 2003 11:20:36 +0900 (JST) Received: from KEI (unknown [10.145.105.81]) by mrkaisv.hoku.renesas.com (Postfix) with SMTP id 299647984BB; Thu, 7 Aug 2003 11:20:36 +0900 (JST) Message-ID: <00bb01c35c8a$b0142ba0$5169910a@KEI> From: "Kei Sakamoto" To: "Daniel Jacobowitz" Cc: References: <028801c35a51$47db96d0$5169910a@KEI> <20030805180235.GA30002@nevyn.them.org> <009b01c35bbc$dff15420$5169910a@KEI> <20030806130352.GA25689@nevyn.them.org> Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error Date: Thu, 07 Aug 2003 02:20:00 -0000 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_NextPart_000_00B8_01C35CD6.1FE98420" X-Priority: 3 X-MSMail-Priority: Normal X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 X-SW-Source: 2003-08/txt/msg00082.txt.bz2 This is a multi-part message in MIME format. ------=_NextPart_000_00B8_01C35CD6.1FE98420 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-length: 893 > -nostartfiles should prevent the inclusion of crt* but not of libgloss; > libgloss is a matter for -nostdlib, which we _don't_ use. I see that > in the m32r GCC port, -lgloss is in ENDFILE_CPU_SPEC, which is unlike > any other port. > > I don't want to mess with that right now, but does adding -lgloss to > ${link-flags} in asm-source.exp fix the problem? It worked. I removed the declarations of symbols from the patch. By the way, I noticed another bug in m32r.inc. In m32r.inc, there is a sequential nop after bl instruction, which is illegal. M32r simulator doesn't care about it, but real m32r chips cause exceptions. The attached new patch fixes this problem too. Kei === 2003-08-07 Kei Sakamoto * gdb.asm/asm-source.exp : Add -lgloss to link-flags. * gdb.asm/m32r.inc : Remove an illegal nop after bl instruction. Replace ld24 with seth/add3. ------=_NextPart_000_00B8_01C35CD6.1FE98420 Content-Type: application/octet-stream; name="diffs" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="diffs" Content-length: 1138 diff -Naur src.orig/gdb/testsuite/gdb.asm/asm-source.exp src/gdb/testsuite/= gdb.asm/asm-source.exp=0A= --- src.orig/gdb/testsuite/gdb.asm/asm-source.exp 2003-07-16 02:23:32.00000= 0000 +0900=0A= +++ src/gdb/testsuite/gdb.asm/asm-source.exp 2003-08-07 10:11:20.000000000 = +0900=0A= @@ -69,6 +69,7 @@=0A= }=0A= "m32r*-*" {=0A= set asm-arch m32r=0A= + set link-flags "-Wl,--whole-archive -lgloss -Wl,--no-whole-archive= "=0A= }=0A= "m6811-*-*" {=0A= set asm-arch m68hc11=0A= diff -Naur src.orig/gdb/testsuite/gdb.asm/m32r.inc src/gdb/testsuite/gdb.as= m/m32r.inc=0A= --- src.orig/gdb/testsuite/gdb.asm/m32r.inc 2001-11-22 10:13:10.000000000 += 0900=0A= +++ src/gdb/testsuite/gdb.asm/m32r.inc 2003-08-07 11:05:13.000000000 +0900= =0A= @@ -11,7 +11,7 @@=0A= .endm=0A= =20=0A= .macro gdbasm_call subr=0A= - bl \subr -> nop=0A= + bl \subr=0A= .endm=0A= =20=0A= .macro gdbasm_several_nops=0A= @@ -30,6 +30,7 @@=0A= =20=0A= comment "crt0 startup"=0A= .macro gdbasm_startup=0A= - ld24 sp,_stack=0A= + seth sp, #shigh(_stack)=0A= + add3 sp, sp, #low(_stack)=0A= ldi fp,#0=0A= .endm=0A= ------=_NextPart_000_00B8_01C35CD6.1FE98420--