From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10076 invoked by alias); 5 Aug 2003 18:02:46 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10065 invoked from network); 5 Aug 2003 18:02:45 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 5 Aug 2003 18:02:45 -0000 Received: from drow by nevyn.them.org with local (Exim 4.20 #1 (Debian)) id 19k68p-0007qT-GY; Tue, 05 Aug 2003 14:02:35 -0400 Date: Tue, 05 Aug 2003 18:02:00 -0000 From: Daniel Jacobowitz To: Kei Sakamoto Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/testcase] gdb.asm/m32r.inc: fix compile error Message-ID: <20030805180235.GA30002@nevyn.them.org> Mail-Followup-To: Kei Sakamoto , gdb-patches@sources.redhat.com References: <028801c35a51$47db96d0$5169910a@KEI> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <028801c35a51$47db96d0$5169910a@KEI> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-08/txt/msg00062.txt.bz2 On Mon, Aug 04, 2003 at 03:26:03PM +0900, Kei Sakamoto wrote: > Thank you, everyone. Now m32r is back! :-) > > The attached fixes compile errors of asm-source.exp for m32r-elf. > There are several missing symbols. > > It also replaces ld24 instruction with seth/add3 instruction. > ld24 can handle only 24bit address, so ld24 fails to set sp when > _stack is located at a large address. > > Kei Sakamoto > > === > > 2003-08-04 Kei Sakamoto > > * gdb.asm/m32r.inc : Add several missing symbols. Replace ld24 > with seth/add3. Two minor things: - You accidentally sent a reversed diff. - ChangeLog formatting. It should be: 2003-08-04 Kei Sakamoto * gdb.asm/m32r.inc: Add several missing symbols. Replace ld24 with seth/add3. One less minor thing: no other port needs to declare symbols. It looks like part of libc is being dragged in somehow on m32r; could you explain why the symbols are necessary? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer