Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: "gdb-patches@sources.redhat.com" <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] varobj: call CHECK_TYPEDEF
Date: Thu, 19 Jun 2003 20:43:00 -0000	[thread overview]
Message-ID: <20030619204118.GC2379@nevyn.them.org> (raw)
In-Reply-To: <1056055095.1577.10.camel@lindt.uglyboxes.com>

On Thu, Jun 19, 2003 at 01:38:16PM -0700, Keith Seitz wrote:
> On Thu, 2003-06-19 at 12:45, Daniel Jacobowitz wrote:
> > > That doesn't dereference pointers and references!  It looks like
> > > get_type got inserted between get_type_deref and its comments?  Can you
> > > confirm that it shouldn't dereference?
> 
> Yes, I believe the comment is wrong. There is another function to do
> dereferences...
> 
> > I take that back.  Test results are abominable; everything crashes
> > because I misunderstood the use of get_target_type.  Try this patch.
> 
> Your patch passes all the insight varobj tests (c_variable.exp,
> cpp_variable.exp, insight219.exp). We still have the one (existing)
> failure, as expected (aka: gcc bug, as I recall).
> 
> Anyway, I would like to encourage you to check this patch in (and you
> could close insight/219, too :-)

I've checked it in.  I can't edit the insight PR database, though.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-06-19 20:43 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-24 20:47 Keith Seitz
2003-04-24 20:52 ` Daniel Jacobowitz
2003-04-24 21:51   ` Keith Seitz
2003-04-24 21:55     ` Daniel Jacobowitz
2003-04-24 22:18       ` Keith Seitz
     [not found] ` <3EA84A9B.5020308@redhat.com>
2003-04-24 22:27   ` Keith Seitz
2003-04-24 22:31     ` Andrew Cagney
2003-04-25  0:18       ` Keith Seitz
2003-04-25  2:15         ` Daniel Jacobowitz
2003-04-25  3:47           ` Andrew Cagney
2003-04-25  5:32             ` Daniel Jacobowitz
2003-06-11 20:07       ` Keith Seitz
2003-06-11 21:01         ` Andrew Cagney
2003-06-11 23:51         ` David Carlton
2003-06-12  0:28           ` Keith Seitz
2003-06-12  1:28             ` Daniel Jacobowitz
2003-06-19 19:28               ` Daniel Jacobowitz
2003-06-19 19:53                 ` Daniel Jacobowitz
2003-06-19 20:33                   ` Keith Seitz
2003-06-19 20:43                     ` Daniel Jacobowitz [this message]
2003-06-19 21:30                       ` Keith Seitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030619204118.GC2379@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox