From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28044 invoked by alias); 19 Jun 2003 20:43:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24413 invoked from network); 19 Jun 2003 20:41:30 -0000 Received: from unknown (HELO crack.them.org) (146.82.138.56) by sources.redhat.com with SMTP; 19 Jun 2003 20:41:30 -0000 Received: from dsl093-172-017.pit1.dsl.speakeasy.net ([66.93.172.17] helo=nevyn.them.org ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 19T6Ee-0002BD-00 for ; Thu, 19 Jun 2003 15:42:20 -0500 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 19T6Df-0006ud-00 for ; Thu, 19 Jun 2003 16:41:19 -0400 Date: Thu, 19 Jun 2003 20:43:00 -0000 From: Daniel Jacobowitz To: "gdb-patches@sources.redhat.com" Subject: Re: [RFA] varobj: call CHECK_TYPEDEF Message-ID: <20030619204118.GC2379@nevyn.them.org> Mail-Followup-To: "gdb-patches@sources.redhat.com" References: <3EA84A9B.5020308@redhat.com> <1051221433.1534.72.camel@lindt.uglyboxes.com> <3EA8629B.50603@redhat.com> <1055362509.1571.63.camel@lindt.uglyboxes.com> <1055378162.1571.98.camel@lindt.uglyboxes.com> <20030612012810.GA21583@nevyn.them.org> <20030619192845.GA2379@nevyn.them.org> <20030619194513.GA7225@nevyn.them.org> <1056055095.1577.10.camel@lindt.uglyboxes.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1056055095.1577.10.camel@lindt.uglyboxes.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-06/txt/msg00641.txt.bz2 On Thu, Jun 19, 2003 at 01:38:16PM -0700, Keith Seitz wrote: > On Thu, 2003-06-19 at 12:45, Daniel Jacobowitz wrote: > > > That doesn't dereference pointers and references! It looks like > > > get_type got inserted between get_type_deref and its comments? Can you > > > confirm that it shouldn't dereference? > > Yes, I believe the comment is wrong. There is another function to do > dereferences... > > > I take that back. Test results are abominable; everything crashes > > because I misunderstood the use of get_target_type. Try this patch. > > Your patch passes all the insight varobj tests (c_variable.exp, > cpp_variable.exp, insight219.exp). We still have the one (existing) > failure, as expected (aka: gcc bug, as I recall). > > Anyway, I would like to encourage you to check this patch in (and you > could close insight/219, too :-) I've checked it in. I can't edit the insight PR database, though. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer