From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c
Date: Wed, 04 Jun 2003 20:41:00 -0000 [thread overview]
Message-ID: <20030604204125.GO926@gnat.com> (raw)
In-Reply-To: <3EDE2D5B.8070809@redhat.com>
> >I am not sure if it is really worth fixing this sort of thing now, or
> >worry about it later... You know the grand plan, so your call.
>
> If the change is straight forward, might as well. If it's a struggle,
> don't bother - I'll be looking over the code anyway to see where there
> are problems.
Looking more closely, I think it's not worth bothering yet, because this
call actually hides a small cast from LONGEST to CORE_ADDR, which is not
fancied (such explicit casts are even flagged by the ARI, IIRC).
If I were to "fix" this, I would replace the call to read_memory_integer
by a call to read_memory_typed_address. But this does not have a frame
equivalent. Maybe that's something that we will have to add in the
future?
--
Joel
prev parent reply other threads:[~2003-06-04 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 0:27 Joel Brobecker
2003-06-04 2:47 ` Andrew Cagney
2003-06-04 5:31 ` Joel Brobecker
2003-06-04 6:05 ` Joel Brobecker
2003-06-04 17:33 ` Andrew Cagney
2003-06-04 17:40 ` David Carlton
2003-06-04 20:41 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604204125.GO926@gnat.com \
--to=brobecker@gnat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox