From: Andrew Cagney <ac131313@redhat.com>
To: Joel Brobecker <brobecker@gnat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c
Date: Wed, 04 Jun 2003 17:33:00 -0000 [thread overview]
Message-ID: <3EDE2D5B.8070809@redhat.com> (raw)
In-Reply-To: <20030604060512.GW919@gnat.com>
>> >2003-06-03 J. Brobecker <brobecker@gnat.com>
>> >
>> > * alpha-osf1-tdep.c (alpha_osf1_skip_sigtramp_frame): Replace
>> > references to struct frame_info fields by calls to the equivalent
>> > accessors. Necessary now that frame_info is opaque.
>> > (alpha_osf1_pc_in_sigtramp): Likewise.
>> >
>> >Looks ok?
>
>>
>> Yes. If you're feeling game you could use get_frame_memory, but
>> either way.
>
>
> Andrew, please forgive for not having followed the discussions about
> the new frame architecture too closely (I did go and read the messages
> you recently pointed out to Daniel, though!).
>
> You are saying either way; however, my current understanding is that
> get_frame_memory is not currently any different from the above, but
> is still a better approach in the long run if we eventually want to be
> multi-everything. Is it correct?
Yes.
> I am not sure if it is really worth fixing this sort of thing now, or
> worry about it later... You know the grand plan, so your call.
If the change is straight forward, might as well. If it's a struggle,
don't bother - I'll be looking over the code anyway to see where there
are problems. I'm also pretty sure that there is going to be a new
architecture method so that:
xxx_frame__yyy (get_frame_arch (frame), frame, ...)
can be written as:
xxx_frame_yyy (frame, ....);
Anyway, to scare you :-)
There is some interest in fixing GDB's Java. [insert manditory slander
directed towards the old code] The current implementation has more
limitiations than one can point a stick at. Off the top of my head:
- namespaces
- bytecodes and a byte code target
- backtraces through libffi
To get these working, it's going to be especially important to avoid
globals such as current_gdbarch.
Anyway, I think the first thing is get the infrastructure working here.
Andrew
next prev parent reply other threads:[~2003-06-04 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 0:27 Joel Brobecker
2003-06-04 2:47 ` Andrew Cagney
2003-06-04 5:31 ` Joel Brobecker
2003-06-04 6:05 ` Joel Brobecker
2003-06-04 17:33 ` Andrew Cagney [this message]
2003-06-04 17:40 ` David Carlton
2003-06-04 20:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EDE2D5B.8070809@redhat.com \
--to=ac131313@redhat.com \
--cc=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox