From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c
Date: Wed, 04 Jun 2003 05:31:00 -0000 [thread overview]
Message-ID: <20030604053058.GS919@gnat.com> (raw)
In-Reply-To: <3EDD5DAA.1060300@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
> Yes. If you're feeling game you could use get_frame_memory, but either way.
I will have a look at get_frame_memory, at least just out of curiosity.
But right now, here is the patch I ended up committing. Since
alpha_osf1_skip_sigtramp_frame is to be slain in a separate patch,
I didn't include the update in this patch.
2003-06-03 J. Brobecker <brobecker@gnat.com>
* alpha-osf1-tdep.c (alpha_osf1_sigcontext_addr): Replace
references to struct frame_info fields by calls to the equivalent
accessors. Necessary now that frame_info is opaque.
Thanks,
--
Joel
[-- Attachment #2: frame.diff --]
[-- Type: text/plain, Size: 1058 bytes --]
Index: alpha-osf1-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/alpha-osf1-tdep.c,v
retrieving revision 1.12
diff -c -3 -p -r1.12 alpha-osf1-tdep.c
*** alpha-osf1-tdep.c 3 Jun 2003 23:49:32 -0000 1.12
--- alpha-osf1-tdep.c 4 Jun 2003 05:06:58 -0000
*************** alpha_osf1_pc_in_sigtramp (CORE_ADDR pc,
*** 50,57 ****
static CORE_ADDR
alpha_osf1_sigcontext_addr (struct frame_info *frame)
{
! return (read_memory_integer (frame->next ? frame->next->frame
! : frame->frame, 8));
}
/* This is the definition of CALL_DUMMY_ADDRESS. It's a heuristic that is used
--- 37,48 ----
static CORE_ADDR
alpha_osf1_sigcontext_addr (struct frame_info *frame)
{
! struct frame_info *next_frame = get_next_frame (frame);
!
! if (next_frame != NULL)
! return (read_memory_integer (get_frame_base (next_frame), 8));
! else
! return (read_memory_integer (get_frame_base (frame), 8));
}
/* This is the definition of CALL_DUMMY_ADDRESS. It's a heuristic that is used
next prev parent reply other threads:[~2003-06-04 5:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-04 0:27 Joel Brobecker
2003-06-04 2:47 ` Andrew Cagney
2003-06-04 5:31 ` Joel Brobecker [this message]
2003-06-04 6:05 ` Joel Brobecker
2003-06-04 17:33 ` Andrew Cagney
2003-06-04 17:40 ` David Carlton
2003-06-04 20:41 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030604053058.GS919@gnat.com \
--to=brobecker@gnat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox