From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8695 invoked by alias); 4 Jun 2003 20:41:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8536 invoked from network); 4 Jun 2003 20:41:40 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (209.53.16.215) by sources.redhat.com with SMTP; 4 Jun 2003 20:41:40 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 34C68D2DAF; Wed, 4 Jun 2003 13:41:25 -0700 (PDT) Date: Wed, 04 Jun 2003 20:41:00 -0000 From: Joel Brobecker To: Andrew Cagney Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC/RFA/frame stuff] Fix build failure in alpha-osf1-tdep.c Message-ID: <20030604204125.GO926@gnat.com> References: <20030604002702.GP919@gnat.com> <3EDD5DAA.1060300@redhat.com> <20030604060512.GW919@gnat.com> <3EDE2D5B.8070809@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3EDE2D5B.8070809@redhat.com> User-Agent: Mutt/1.4i X-SW-Source: 2003-06/txt/msg00179.txt.bz2 > >I am not sure if it is really worth fixing this sort of thing now, or > >worry about it later... You know the grand plan, so your call. > > If the change is straight forward, might as well. If it's a struggle, > don't bother - I'll be looking over the code anyway to see where there > are problems. Looking more closely, I think it's not worth bothering yet, because this call actually hides a small cast from LONGEST to CORE_ADDR, which is not fancied (such explicit casts are even flagged by the ARI, IIRC). If I were to "fix" this, I would replace the call to read_memory_integer by a call to read_memory_typed_address. But this does not have a frame equivalent. Maybe that's something that we will have to add in the future? -- Joel