[RFA] i386-cygwin-tdep.c

[RFA] i386-cygwin-tdep.c

[Corinna Vinschen]

Hi,

I created a patch to allow switching to reg_struct_return for Cygwin.
According to Andrew's reply on gdb@ I created a new file i386-cygwin-tdep.c
and added everything needed to get it working.

Ok to commit?

Corinna

2003-03-20  Corinna Vinschen  <vinschen@redhat.com>

        * Makefile.in (ALLDEPFILES): Add i386-cygwin-tdep.c.
        (i386-cygwin-tdep.o): Add dependencies.
        * defs.h (enum gdb_osabi): Add GDB_OSABI_CYGWIN.
        * i386-cygwin-tdep.c: New file.
        * osabi.c (gdb_osabi_name): Add string for GDB_OSABI_CYGWIN.
        * config/i386/cygwin.mt (TDEPFILES): Add i386-cygwin-tdep.o.

Index: Makefile.in
===================================================================
RCS file: /cvs/cvsfiles/gnupro/gdb/Makefile.in,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile.in
--- Makefile.in	2003/02/17 06:53:31	1.5
+++ Makefile.in	2003/03/20 21:23:30
@@ -1359,7 +1359,7 @@ ALLDEPFILES = a68v-nat.c \
 	hp300ux-nat.c hppa-tdep.c hppa-hpux-tdep.c \
 	hppab-nat.c hppah-nat.c hpread.c \
 	i386-tdep.c i386b-nat.c i386v-nat.c i386-linux-nat.c \
-	i386v4-nat.c i386ly-tdep.c \
+	i386v4-nat.c i386ly-tdep.c i386-cygwin-tdep.c \
 	i386bsd-nat.c i386bsd-tdep.c i386fbsd-nat.c \
 	i387-tdep.c \
 	i386-linux-tdep.c i386-nat.c \
@@ -1785,6 +1785,8 @@ i386gnu-nat.o: i386gnu-nat.c $(defs_h) $
 i386gnu-tdep.o: i386gnu-tdep.c $(defs_h) $(i386_tdep_h) $(osabi_h)
 i386ly-tdep.o: i386ly-tdep.c $(defs_h) $(gdbcore_h) $(inferior_h) \
 	$(regcache_h) $(target_h) $(i386_tdep_h) $(osabi_h)
+i386-cygwin-tdep.o: i386-cygwin-tdep.c $(defs_h) $(gdb_string_h) \
+	$(i386_tdep_h) $(osabi_h)
 i386nbsd-tdep.o: i386nbsd-tdep.c $(defs_h) $(gdbtypes_h) $(gdbcore_h) \
 	$(regcache_h) $(arch_utils_h) $(i386_tdep_h) $(i387_tdep_h) \
 	$(nbsd_tdep_h) $(solib_svr4_h) $(osabi_h)
Index: defs.h
===================================================================
RCS file: /cvs/cvsfiles/gnupro/gdb/defs.h,v
retrieving revision 1.4
diff -u -p -r1.4 defs.h
--- defs.h	2003/02/16 09:26:47	1.4
+++ defs.h	2003/03/20 21:23:31
@@ -1013,6 +1013,8 @@ enum gdb_osabi
   GDB_OSABI_ARM_EABI_V2,
   GDB_OSABI_ARM_APCS,
 
+  GDB_OSABI_CYGWIN,
+
   GDB_OSABI_INVALID		/* keep this last */
 };
 
Index: i386-cygwin-tdep.c
===================================================================
RCS file: i386-cygwin-tdep.c
diff -N i386-cygwin-tdep.c
--- /dev/null	Thu Aug 24 02:00:32 2000
+++ i386-cygwin-tdep.c	Thu Mar 20 13:23:31 2003
@@ -0,0 +1,53 @@
+/* Target-dependent code for Cygwin running on i386's, for GDB.
+   Copyright 2003 Free Software Foundation, Inc.
+
+This file is part of GDB.
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 2 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program; if not, write to the Free Software
+Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.  */
+
+#include "defs.h"
+
+#include "gdb_string.h"
+#include "i386-tdep.h"
+#include "osabi.h"
+
+static void
+i386_cygwin_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
+{
+  struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
+
+  tdep->struct_return = reg_struct_return;
+}
+
+static enum gdb_osabi
+i386_cygwin_osabi_sniffer (bfd * abfd)
+{ 
+  char *target_name = bfd_get_target (abfd);
+
+  if (strcmp (target_name, "pei-i386") == 0)
+    return GDB_OSABI_CYGWIN;
+
+  return GDB_OSABI_UNKNOWN;
+}
+
+void
+_initialize_i386_cygwin_tdep (void)
+{
+  gdbarch_register_osabi_sniffer (bfd_arch_i386, bfd_target_coff_flavour,
+                                  i386_cygwin_osabi_sniffer);
+
+  gdbarch_register_osabi (bfd_arch_i386, 0, GDB_OSABI_CYGWIN,
+                          i386_cygwin_init_abi);
+}
Index: osabi.c
===================================================================
RCS file: /cvs/cvsfiles/gnupro/gdb/osabi.c,v
retrieving revision 1.2
diff -u -p -r1.2 osabi.c
--- osabi.c	2003/02/16 09:26:49	1.2
+++ osabi.c	2003/03/20 21:23:31
@@ -73,6 +73,8 @@ static const char * const gdb_osabi_name
   "ARM EABI v2",
   "ARM APCS",
 
+  "Cygwin",
+
   "<invalid>"
 };
 
Index: config/i386/cygwin.mt
===================================================================
RCS file: /cvs/cvsfiles/gnupro/gdb/config/i386/cygwin.mt,v
retrieving revision 1.1
diff -u -p -r1.1 cygwin.mt
--- cygwin.mt	2002/11/04 16:29:47	1.1
+++ cygwin.mt	2003/03/20 21:23:31
@@ -1,5 +1,5 @@
 # Target: Intel 386 run win32
-TDEPFILES= i386-tdep.o i387-tdep.o
+TDEPFILES= i386-tdep.o i386-cygwin-tdep.o i387-tdep.o
 TM_FILE= tm-cygwin.h
 
 

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com

Re: [RFA] i386-cygwin-tdep.c

[Mark Kettenis]

Corinna Vinschen <vinschen@redhat.com> writes:

> I created a patch to allow switching to reg_struct_return for Cygwin.
> According to Andrew's reply on gdb@ I created a new file i386-cygwin-tdep.c
> and added everything needed to get it working.
> 
> Ok to commit?

Hmm, Interix also has a sniffer that detects pei-i386, so installing
this patch rules out having a GDB that supports.  It would be great if
you could find a clever way to distinguish between the two.  However,
in the current state of affairs, with Interix not being in a working
state yet, this patch is fine.  Could you add a comment in
i386_cygwin_osabi_sniffer that Interix also uses pei-i386 and that we
need a way to distinguish between the to?  Consider a patch with that
change pre-approved.

Mark

Re: [RFA] i386-cygwin-tdep.c

[Corinna Vinschen]

On Fri, Mar 21, 2003 at 10:11:06AM +0100, Mark Kettenis wrote:
> Hmm, Interix also has a sniffer that detects pei-i386, so installing
> this patch rules out having a GDB that supports.  It would be great if
> you could find a clever way to distinguish between the two.  However,

That would be cool but I have no access to Interix.

> in the current state of affairs, with Interix not being in a working
> state yet, this patch is fine.  Could you add a comment in
> i386_cygwin_osabi_sniffer that Interix also uses pei-i386 and that we
> need a way to distinguish between the to?  Consider a patch with that
> change pre-approved.

Thanks, I've added a comment and applied the patch.

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen@redhat.com