From: Mark Kettenis <kettenis@chello.nl>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] i386-cygwin-tdep.c
Date: Fri, 21 Mar 2003 09:11:00 -0000 [thread overview]
Message-ID: <86smthw0d1.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: Corinna Vinschen's message of "Thu, 20 Mar 2003 22:37:08 +0100"
Corinna Vinschen <vinschen@redhat.com> writes:
> I created a patch to allow switching to reg_struct_return for Cygwin.
> According to Andrew's reply on gdb@ I created a new file i386-cygwin-tdep.c
> and added everything needed to get it working.
>
> Ok to commit?
Hmm, Interix also has a sniffer that detects pei-i386, so installing
this patch rules out having a GDB that supports. It would be great if
you could find a clever way to distinguish between the two. However,
in the current state of affairs, with Interix not being in a working
state yet, this patch is fine. Could you add a comment in
i386_cygwin_osabi_sniffer that Interix also uses pei-i386 and that we
need a way to distinguish between the to? Consider a patch with that
change pre-approved.
Mark
next prev parent reply other threads:[~2003-03-21 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-20 21:37 Corinna Vinschen
2003-03-21 9:11 ` Mark Kettenis [this message]
2003-03-21 10:12 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86smthw0d1.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox