From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2316 invoked by alias); 21 Mar 2003 09:11:12 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2299 invoked from network); 21 Mar 2003 09:11:08 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (62.163.169.212) by sources.redhat.com with SMTP; 21 Mar 2003 09:11:08 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6/8.12.5) with ESMTP id h2L9B7xm001413 for ; Fri, 21 Mar 2003 10:11:07 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6/8.12.6) with ESMTP id h2L9B7sN000364 for ; Fri, 21 Mar 2003 10:11:07 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6/8.12.6/Submit) id h2L9B6k7000361; Fri, 21 Mar 2003 10:11:06 +0100 (CET) To: gdb-patches@sources.redhat.com Subject: Re: [RFA] i386-cygwin-tdep.c References: <20030320213708.GP21269@cygbert.vinschen.de> From: Mark Kettenis Date: Fri, 21 Mar 2003 09:11:00 -0000 In-Reply-To: Corinna Vinschen's message of "Thu, 20 Mar 2003 22:37:08 +0100" Message-ID: <86smthw0d1.fsf@elgar.kettenis.dyndns.org> X-SW-Source: 2003-03/txt/msg00449.txt.bz2 Corinna Vinschen writes: > I created a patch to allow switching to reg_struct_return for Cygwin. > According to Andrew's reply on gdb@ I created a new file i386-cygwin-tdep.c > and added everything needed to get it working. > > Ok to commit? Hmm, Interix also has a sniffer that detects pei-i386, so installing this patch rules out having a GDB that supports. It would be great if you could find a clever way to distinguish between the two. However, in the current state of affairs, with Interix not being in a working state yet, this patch is fine. Could you add a comment in i386_cygwin_osabi_sniffer that Interix also uses pei-i386 and that we need a way to distinguish between the to? Consider a patch with that change pre-approved. Mark