* gdb.asm/arm.inc tweak
@ 2003-01-17 21:37 Mark Salter
2003-02-01 1:29 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Mark Salter @ 2003-01-17 21:37 UTC (permalink / raw)
To: gdb-patches
Here's a small tweak to fix asm tests on arm boards. Clearly, we
don't want to clear $sp. It looked like the intent was to clear
the frame pointer to limit backtraces.
--Mark
2003-01-17 Mark Salter <msalter@redhat.com>
* gdb.asm/arm.inc (gdbasm_startup): Clear fp and r7 (thumb fp), not sp.
Index: testsuite/gdb.asm/arm.inc
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/arm.inc,v
retrieving revision 1.1
diff -u -p -5 -r1.1 arm.inc
--- testsuite/gdb.asm/arm.inc 20 Dec 2001 22:12:20 -0000 1.1
+++ testsuite/gdb.asm/arm.inc 17 Jan 2003 21:35:28 -0000
@@ -27,8 +27,9 @@
swi 0x00123456
.endm
comment "crt0 startup"
.macro gdbasm_startup
- mov sp, #0
+ mov fp, #0
+ mov r7, #0
.endm
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gdb.asm/arm.inc tweak
2003-01-17 21:37 gdb.asm/arm.inc tweak Mark Salter
@ 2003-02-01 1:29 ` Michael Snyder
2003-02-01 12:13 ` Richard Earnshaw
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2003-02-01 1:29 UTC (permalink / raw)
To: Mark Salter; +Cc: gdb-patches, rearnsha
Mark Salter wrote:
>
> Here's a small tweak to fix asm tests on arm boards. Clearly, we
> don't want to clear $sp. It looked like the intent was to clear
> the frame pointer to limit backtraces.
You're right about the intent. I think your change is right,
but it would be nice if Richard Earnshaw would comment on it.
>
> --Mark
>
> 2003-01-17 Mark Salter <msalter@redhat.com>
>
> * gdb.asm/arm.inc (gdbasm_startup): Clear fp and r7 (thumb fp), not sp.
>
> Index: testsuite/gdb.asm/arm.inc
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/arm.inc,v
> retrieving revision 1.1
> diff -u -p -5 -r1.1 arm.inc
> --- testsuite/gdb.asm/arm.inc 20 Dec 2001 22:12:20 -0000 1.1
> +++ testsuite/gdb.asm/arm.inc 17 Jan 2003 21:35:28 -0000
> @@ -27,8 +27,9 @@
> swi 0x00123456
> .endm
>
> comment "crt0 startup"
> .macro gdbasm_startup
> - mov sp, #0
> + mov fp, #0
> + mov r7, #0
> .endm
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: gdb.asm/arm.inc tweak
2003-02-01 1:29 ` Michael Snyder
@ 2003-02-01 12:13 ` Richard Earnshaw
0 siblings, 0 replies; 3+ messages in thread
From: Richard Earnshaw @ 2003-02-01 12:13 UTC (permalink / raw)
To: Michael Snyder; +Cc: Mark Salter, gdb-patches, rearnsha
> Mark Salter wrote:
> >
> > Here's a small tweak to fix asm tests on arm boards. Clearly, we
> > don't want to clear $sp. It looked like the intent was to clear
> > the frame pointer to limit backtraces.
>
> You're right about the intent. I think your change is right,
> but it would be nice if Richard Earnshaw would comment on it.
Yes, this is fine. Sorry for not replying earlier.
R.
>
> >
> > --Mark
> >
> > 2003-01-17 Mark Salter <msalter@redhat.com>
> >
> > * gdb.asm/arm.inc (gdbasm_startup): Clear fp and r7 (thumb fp), not sp.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-02-01 12:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-17 21:37 gdb.asm/arm.inc tweak Mark Salter
2003-02-01 1:29 ` Michael Snyder
2003-02-01 12:13 ` Richard Earnshaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox