Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Mark Salter <msalter@redhat.com>
Cc: gdb-patches@sources.redhat.com, rearnsha@arm.com
Subject: Re: gdb.asm/arm.inc tweak
Date: Sat, 01 Feb 2003 01:29:00 -0000	[thread overview]
Message-ID: <3E3B22F0.7B892BF8@redhat.com> (raw)
In-Reply-To: <20030117213745.29E037884D@deneb.localdomain>

Mark Salter wrote:
> 
> Here's a small tweak to fix asm tests on arm boards. Clearly, we
> don't want to clear $sp. It looked like the intent was to clear
> the frame pointer to limit backtraces.

You're right about the intent.  I think your change is right, 
but it would be nice if Richard Earnshaw would comment on it.

> 
> --Mark
> 
> 2003-01-17  Mark Salter  <msalter@redhat.com>
> 
>         * gdb.asm/arm.inc (gdbasm_startup): Clear fp and r7 (thumb fp), not sp.
> 
> Index: testsuite/gdb.asm/arm.inc
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/arm.inc,v
> retrieving revision 1.1
> diff -u -p -5 -r1.1 arm.inc
> --- testsuite/gdb.asm/arm.inc   20 Dec 2001 22:12:20 -0000      1.1
> +++ testsuite/gdb.asm/arm.inc   17 Jan 2003 21:35:28 -0000
> @@ -27,8 +27,9 @@
>         swi 0x00123456
>         .endm
> 
>         comment "crt0 startup"
>         .macro gdbasm_startup
> -       mov sp, #0
> +       mov fp, #0
> +       mov r7, #0
>         .endm
>


  reply	other threads:[~2003-02-01  1:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-17 21:37 Mark Salter
2003-02-01  1:29 ` Michael Snyder [this message]
2003-02-01 12:13   ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E3B22F0.7B892BF8@redhat.com \
    --to=msnyder@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msalter@redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox