From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-22149-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 26034 invoked by alias); 1 Feb 2003 01:29:23 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26019 invoked from network); 1 Feb 2003 01:29:23 -0000
Received: from unknown (HELO mx1.redhat.com) (172.16.49.200)
  by 172.16.49.205 with SMTP; 1 Feb 2003 01:29:23 -0000
Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged))
	by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h111TMf14162
	for <gdb-patches@sources.redhat.com>; Fri, 31 Jan 2003 20:29:23 -0500
Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15])
	by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h111TLn13691;
	Fri, 31 Jan 2003 20:29:21 -0500
Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50])
	by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id h111TKQ21498;
	Fri, 31 Jan 2003 17:29:20 -0800
Message-ID: <3E3B22F0.7B892BF8@redhat.com>
Date: Sat, 01 Feb 2003 01:29:00 -0000
From: Michael Snyder <msnyder@redhat.com>
Organization: Red Hat, Inc.
X-Accept-Language: en
MIME-Version: 1.0
To: Mark Salter <msalter@redhat.com>
CC: gdb-patches@sources.redhat.com, rearnsha@arm.com
Subject: Re: gdb.asm/arm.inc tweak
References: <20030117213745.29E037884D@deneb.localdomain>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-SW-Source: 2003-02/txt/msg00007.txt.bz2

Mark Salter wrote:
> 
> Here's a small tweak to fix asm tests on arm boards. Clearly, we
> don't want to clear $sp. It looked like the intent was to clear
> the frame pointer to limit backtraces.

You're right about the intent.  I think your change is right, 
but it would be nice if Richard Earnshaw would comment on it.

> 
> --Mark
> 
> 2003-01-17  Mark Salter  <msalter@redhat.com>
> 
>         * gdb.asm/arm.inc (gdbasm_startup): Clear fp and r7 (thumb fp), not sp.
> 
> Index: testsuite/gdb.asm/arm.inc
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.asm/arm.inc,v
> retrieving revision 1.1
> diff -u -p -5 -r1.1 arm.inc
> --- testsuite/gdb.asm/arm.inc   20 Dec 2001 22:12:20 -0000      1.1
> +++ testsuite/gdb.asm/arm.inc   17 Jan 2003 21:35:28 -0000
> @@ -27,8 +27,9 @@
>         swi 0x00123456
>         .endm
> 
>         comment "crt0 startup"
>         .macro gdbasm_startup
> -       mov sp, #0
> +       mov fp, #0
> +       mov r7, #0
>         .endm
>