From: Daniel Jacobowitz <drow@mvista.com>
To: "J. Johnston" <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com
Subject: Re: Recent MI patches broke the testsuite
Date: Mon, 16 Dec 2002 10:20:00 -0000 [thread overview]
Message-ID: <20021216181759.GA21626@nevyn.them.org> (raw)
In-Reply-To: <3DFE15BA.4080207@redhat.com>
On Mon, Dec 16, 2002 at 01:04:42PM -0500, J. Johnston wrote:
> My bad. :( The new mi-basics.exp testcase is my usual sanity test
> for this change. It was updated and in fact works fine as it is expecting
> the new behavior.
Not in my checkout:
202-environment-directory ../../../src/gdb/testsuite/gdb.mi
202^done,source-path="/opt/src/binutils/x86-as/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd"
(gdb)
FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation
Oh, that's a different problem. Using ${srcdir} that way doesn't work
if configured with a relative srcdir. Just an extra wildcard will fix
it for now.
(i.e. I built this tree with ../../../src/configure)
> I did not look at the correct gdb.log for the full mi testsuite.
> As you have noted, the lib/mi-support.exp routine mi_reinitialize_dir
> is using -environment-directory and is expecting the old output.
>
> I have a patch for lib/mi=support.exp to handle the new syntax which I have
> included. Since I require approval for patches I will revert the
> original patch and resubmit with the added change unless Elena says
> otherwise.
Thank you very much for following up on this! The testsuite patch
looks reasonable to my inexperienced eye.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-12-16 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-15 13:38 Daniel Jacobowitz
2002-12-16 10:10 ` J. Johnston
2002-12-16 10:20 ` Daniel Jacobowitz [this message]
2002-12-16 10:22 ` Elena Zannoni
2002-12-16 10:34 ` Daniel Jacobowitz
2002-12-16 16:40 ` J. Johnston
2002-12-16 10:38 ` Jason Molenda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021216181759.GA21626@nevyn.them.org \
--to=drow@mvista.com \
--cc=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jjohnstn@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox