From: Jason Molenda <jason-swarelist@molenda.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Recent MI patches broke the testsuite
Date: Mon, 16 Dec 2002 10:38:00 -0000 [thread overview]
Message-ID: <20021216103808.A51244@molenda.com> (raw)
In-Reply-To: <20021215211132.GA31984@nevyn.them.org>; from drow@mvista.com on Sun, Dec 15, 2002 at 04:11:32PM -0500
On Sun, Dec 15, 2002 at 04:11:32PM -0500, Daniel Jacobowitz wrote:
> Not only did it break several tests in gdb.mi/, it also broke the utility
> function mi_gdb_reinitialize_dir in lib/mi-support.exp. This causes all my
> testsuite runs to time out. Please don't commit patches like this without
> testing them.
Remarkably enough, these two patches from over a month ago:
Fixing MI frame tuple output when there is a call dummy or signal frame
on the stack, includes test cases for new output:
http://sources.redhat.com/ml/gdb-patches/2002-11/msg00274.html
Fixing var-list-children's response so CHILDREN is a list instead of
a tuple, includes updates to testsuite and doc fix (already approved
by Eli):
http://sources.redhat.com/ml/gdb-patches/2002-11/msg00287.html
Do not break the testsuite. They also include a brand new test
case for the corrected output, updates to the testsuite in the
other, and documentation fixes where needed. Remarkable specimens
of patchy goodness, if I may say so myself.
And yet (cue violins) they languish...
Jason
prev parent reply other threads:[~2002-12-16 18:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-15 13:38 Daniel Jacobowitz
2002-12-16 10:10 ` J. Johnston
2002-12-16 10:20 ` Daniel Jacobowitz
2002-12-16 10:22 ` Elena Zannoni
2002-12-16 10:34 ` Daniel Jacobowitz
2002-12-16 16:40 ` J. Johnston
2002-12-16 10:38 ` Jason Molenda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021216103808.A51244@molenda.com \
--to=jason-swarelist@molenda.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox