From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23877 invoked by alias); 16 Dec 2002 18:38:13 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 23858 invoked from network); 16 Dec 2002 18:38:08 -0000 Received: from unknown (HELO molenda.com) (192.220.74.81) by sources.redhat.com with SMTP; 16 Dec 2002 18:38:08 -0000 Received: (qmail 51951 invoked by uid 19025); 16 Dec 2002 18:38:08 -0000 Date: Mon, 16 Dec 2002 10:38:00 -0000 From: Jason Molenda To: gdb-patches@sources.redhat.com Subject: Re: Recent MI patches broke the testsuite Message-ID: <20021216103808.A51244@molenda.com> References: <20021215211132.GA31984@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20021215211132.GA31984@nevyn.them.org>; from drow@mvista.com on Sun, Dec 15, 2002 at 04:11:32PM -0500 X-SW-Source: 2002-12/txt/msg00493.txt.bz2 On Sun, Dec 15, 2002 at 04:11:32PM -0500, Daniel Jacobowitz wrote: > Not only did it break several tests in gdb.mi/, it also broke the utility > function mi_gdb_reinitialize_dir in lib/mi-support.exp. This causes all my > testsuite runs to time out. Please don't commit patches like this without > testing them. Remarkably enough, these two patches from over a month ago: Fixing MI frame tuple output when there is a call dummy or signal frame on the stack, includes test cases for new output: http://sources.redhat.com/ml/gdb-patches/2002-11/msg00274.html Fixing var-list-children's response so CHILDREN is a list instead of a tuple, includes updates to testsuite and doc fix (already approved by Eli): http://sources.redhat.com/ml/gdb-patches/2002-11/msg00287.html Do not break the testsuite. They also include a brand new test case for the corrected output, updates to the testsuite in the other, and documentation fixes where needed. Remarkable specimens of patchy goodness, if I may say so myself. And yet (cue violins) they languish... Jason