From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12262 invoked by alias); 16 Dec 2002 18:17:01 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12150 invoked from network); 16 Dec 2002 18:16:59 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 16 Dec 2002 18:16:59 -0000 Received: from nevyn.them.org ([66.93.61.169] ident=mail) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 18O1g2-0004Gp-00; Mon, 16 Dec 2002 14:17:22 -0600 Received: from drow by nevyn.them.org with local (Exim 3.36 #1 (Debian)) id 18NzoV-0005kR-00; Mon, 16 Dec 2002 13:17:59 -0500 Date: Mon, 16 Dec 2002 10:20:00 -0000 From: Daniel Jacobowitz To: "J. Johnston" Cc: gdb-patches@sources.redhat.com, ezannoni@redhat.com Subject: Re: Recent MI patches broke the testsuite Message-ID: <20021216181759.GA21626@nevyn.them.org> Mail-Followup-To: "J. Johnston" , gdb-patches@sources.redhat.com, ezannoni@redhat.com References: <20021215211132.GA31984@nevyn.them.org> <3DFE15BA.4080207@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DFE15BA.4080207@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-12/txt/msg00489.txt.bz2 On Mon, Dec 16, 2002 at 01:04:42PM -0500, J. Johnston wrote: > My bad. :( The new mi-basics.exp testcase is my usual sanity test > for this change. It was updated and in fact works fine as it is expecting > the new behavior. Not in my checkout: 202-environment-directory ../../../src/gdb/testsuite/gdb.mi 202^done,source-path="/opt/src/binutils/x86-as/gdb/testsuite/../../../src/gdb/testsuite/gdb.mi:$cdir:$cwd" (gdb) FAIL: gdb.mi/mi-basics.exp: environment-directory arg operation Oh, that's a different problem. Using ${srcdir} that way doesn't work if configured with a relative srcdir. Just an extra wildcard will fix it for now. (i.e. I built this tree with ../../../src/configure) > I did not look at the correct gdb.log for the full mi testsuite. > As you have noted, the lib/mi-support.exp routine mi_reinitialize_dir > is using -environment-directory and is expecting the old output. > > I have a patch for lib/mi=support.exp to handle the new syntax which I have > included. Since I require approval for patches I will revert the > original patch and resubmit with the added change unless Elena says > otherwise. Thank you very much for following up on this! The testsuite patch looks reasonable to my inexperienced eye. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer