m68k-linux native broken

m68k-linux native broken

[Daniel Jacobowitz]

Tsk tsk... this patch:

2002-07-02  Grace Sainsbury  <graces@redhat.com>

        * m68k-tdep.c (m68k_remote_breakpoint_from_pc): Add. Currently not
        used in architecture vector. The default is
        m68k_local_breakpoint_from_pc.
        (m68k_local_breakpoint_from_pc): Add.
        (enum): Add register numbers from tm-m68k.h.
        (m68k_gdbarch_init): Add breakpoint_from_pc to architecture
        vector.  
        * config/m68k/tm-m68k.h (GDB_MULTI_ARCH): Set to
        GDB_MULTI_ARCH_PARTIAL.
        (BPT_VECTOR, REGISTER_BYTES_FP, REGISTER_BYTES_NOFP)
        (NUM_FREGS, SIG_PC_FP_OFFSET, SP_ARG0, REMOTE_BPT_VECTOR): Move to
        m68k-tdep.c.
        (BREAKPOINT, REMOTE_BREAKPOINT): Remove.
        (A1_REGNUM, FP0_REGNUM, FPC_REGNUM, FPS_REGNUM, FPI_REGNUM): Move
        to enum in m68k-tdep.c

did not check for other users of the values being moved.  I believe that
delta68-nat.c, remote-vx68.c, sun3-nat.c, and m68klinux-nat.c were all
broken by this change.  Those aren't all obsolete targets.

They should probably go in an m68k-tdep.h file.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

Re: m68k-linux native broken

[Andrew Cagney]

> Tsk tsk... this patch:

Tut, tut, youself :-)

> 2002-07-02  Grace Sainsbury  <graces@redhat.com>
> 
>         * m68k-tdep.c (m68k_remote_breakpoint_from_pc): Add. Currently not
>         used in architecture vector. The default is
>         m68k_local_breakpoint_from_pc.
>         (m68k_local_breakpoint_from_pc): Add.
>         (enum): Add register numbers from tm-m68k.h.
>         (m68k_gdbarch_init): Add breakpoint_from_pc to architecture
>         vector.  
>         * config/m68k/tm-m68k.h (GDB_MULTI_ARCH): Set to
>         GDB_MULTI_ARCH_PARTIAL.
>         (BPT_VECTOR, REGISTER_BYTES_FP, REGISTER_BYTES_NOFP)
>         (NUM_FREGS, SIG_PC_FP_OFFSET, SP_ARG0, REMOTE_BPT_VECTOR): Move to
>         m68k-tdep.c.
>         (BREAKPOINT, REMOTE_BREAKPOINT): Remove.
>         (A1_REGNUM, FP0_REGNUM, FPC_REGNUM, FPS_REGNUM, FPI_REGNUM): Move
>         to enum in m68k-tdep.c
> 
> did not check for other users of the values being moved.  I believe that
> delta68-nat.c, remote-vx68.c, sun3-nat.c, and m68klinux-nat.c were all
> broken by this change.  Those aren't all obsolete targets.

Yep, that's the risk we take in getting something multi-arched.  Better 
a bit of breakage then no target at all (e.g., i960 :-).

> They should probably go in an m68k-tdep.h file.

True (BTW, Grace is back at uni at present so may not be the one fixing 
this).

Andrew