From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11851 invoked by alias); 22 Nov 2002 00:06:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11844 invoked from network); 22 Nov 2002 00:05:59 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 22 Nov 2002 00:05:59 -0000 Received: from redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D6FA93E4B; Thu, 21 Nov 2002 19:05:52 -0500 (EST) Message-ID: <3DDD74E0.4030207@redhat.com> Date: Thu, 21 Nov 2002 16:06:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020824 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: m68k-linux native broken References: <20021121201117.GA20186@nevyn.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-11/txt/msg00528.txt.bz2 > Tsk tsk... this patch: Tut, tut, youself :-) > 2002-07-02 Grace Sainsbury > > * m68k-tdep.c (m68k_remote_breakpoint_from_pc): Add. Currently not > used in architecture vector. The default is > m68k_local_breakpoint_from_pc. > (m68k_local_breakpoint_from_pc): Add. > (enum): Add register numbers from tm-m68k.h. > (m68k_gdbarch_init): Add breakpoint_from_pc to architecture > vector. > * config/m68k/tm-m68k.h (GDB_MULTI_ARCH): Set to > GDB_MULTI_ARCH_PARTIAL. > (BPT_VECTOR, REGISTER_BYTES_FP, REGISTER_BYTES_NOFP) > (NUM_FREGS, SIG_PC_FP_OFFSET, SP_ARG0, REMOTE_BPT_VECTOR): Move to > m68k-tdep.c. > (BREAKPOINT, REMOTE_BREAKPOINT): Remove. > (A1_REGNUM, FP0_REGNUM, FPC_REGNUM, FPS_REGNUM, FPI_REGNUM): Move > to enum in m68k-tdep.c > > did not check for other users of the values being moved. I believe that > delta68-nat.c, remote-vx68.c, sun3-nat.c, and m68klinux-nat.c were all > broken by this change. Those aren't all obsolete targets. Yep, that's the risk we take in getting something multi-arched. Better a bit of breakage then no target at all (e.g., i960 :-). > They should probably go in an m68k-tdep.h file. True (BTW, Grace is back at uni at present so may not be the one fixing this). Andrew