Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: m68k-linux native broken
Date: Thu, 21 Nov 2002 16:06:00 -0000	[thread overview]
Message-ID: <3DDD74E0.4030207@redhat.com> (raw)
In-Reply-To: <20021121201117.GA20186@nevyn.them.org>

> Tsk tsk... this patch:

Tut, tut, youself :-)

> 2002-07-02  Grace Sainsbury  <graces@redhat.com>
> 
>         * m68k-tdep.c (m68k_remote_breakpoint_from_pc): Add. Currently not
>         used in architecture vector. The default is
>         m68k_local_breakpoint_from_pc.
>         (m68k_local_breakpoint_from_pc): Add.
>         (enum): Add register numbers from tm-m68k.h.
>         (m68k_gdbarch_init): Add breakpoint_from_pc to architecture
>         vector.  
>         * config/m68k/tm-m68k.h (GDB_MULTI_ARCH): Set to
>         GDB_MULTI_ARCH_PARTIAL.
>         (BPT_VECTOR, REGISTER_BYTES_FP, REGISTER_BYTES_NOFP)
>         (NUM_FREGS, SIG_PC_FP_OFFSET, SP_ARG0, REMOTE_BPT_VECTOR): Move to
>         m68k-tdep.c.
>         (BREAKPOINT, REMOTE_BREAKPOINT): Remove.
>         (A1_REGNUM, FP0_REGNUM, FPC_REGNUM, FPS_REGNUM, FPI_REGNUM): Move
>         to enum in m68k-tdep.c
> 
> did not check for other users of the values being moved.  I believe that
> delta68-nat.c, remote-vx68.c, sun3-nat.c, and m68klinux-nat.c were all
> broken by this change.  Those aren't all obsolete targets.

Yep, that's the risk we take in getting something multi-arched.  Better 
a bit of breakage then no target at all (e.g., i960 :-).

> They should probably go in an m68k-tdep.h file.

True (BTW, Grace is back at uni at present so may not be the one fixing 
this).

Andrew



      reply	other threads:[~2002-11-22  0:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-21 12:11 Daniel Jacobowitz
2002-11-21 16:06 ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3DDD74E0.4030207@redhat.com \
    --to=ac131313@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox