Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: Andrew Cagney <ac131313@ges.redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] New bitflags type and eflags on i386/x86-64
Date: Wed, 28 Aug 2002 08:08:00 -0000	[thread overview]
Message-ID: <20020828144901.GA21703@nevyn.them.org> (raw)
In-Reply-To: <3D6CE138.50801@suse.cz>

On Wed, Aug 28, 2002 at 04:42:00PM +0200, Michal Ludvig wrote:
> Andrew Cagney wrote:
> >Attatched is an old and related patch I've dug out of an old branch of 
> >GDB that Red Hat was providing for a customer.
> 
> The mine one is more generic I think, and while it adds new TYPE_CODE it 
> can be used for other purposes as well (IIRC recently someone committed 
> a patch that depended on this type code but had to revert it).
> 
> I'm afraid people don't know how to use the complex, nested 
> TYPE_CODE_SET, while the usage of TYPE_CODE_FLAGS is pretty simple.
> If would change it so that it isn't c-specific, but rather language 
> independent, would you consider approval? Other things (eg. length of 
> the flagword) aren't IMHO that important for now.

But Andrew's patch doesn't require a new infrastructure, which is nice. 
I stand by all my previous objections to your patch.  We have a type
that does this; fix its complex, nested interface, then!  Don't add
more type codes.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2002-08-28 14:48 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-22  8:35 Michal Ludvig
2002-08-27 14:50 ` Andrew Cagney
2002-08-28  7:48   ` Michal Ludvig
2002-08-28  8:08     ` Daniel Jacobowitz [this message]
2002-08-28  8:09       ` Michal Ludvig
2002-08-28 10:03       ` Andrew Cagney
2002-08-29  7:20   ` Michal Ludvig
2002-08-29  7:57     ` Daniel Jacobowitz
2002-08-29  8:03       ` Michal Ludvig
2002-08-29  8:15         ` Daniel Jacobowitz
2002-08-29  8:59           ` Andrew Cagney
2002-08-29 16:37             ` Mark Kettenis
2002-08-30  7:09               ` Michal Ludvig
2002-08-30  7:05             ` Michal Ludvig
2002-08-30  7:12               ` Pierre Muller
2002-08-30  7:41                 ` Michal Ludvig
2002-08-30  8:14                   ` Daniel Jacobowitz
2002-08-30 10:18                     ` Pierre Muller
2002-09-03  2:17                       ` Michal Ludvig
2002-09-03  5:30                         ` Daniel Jacobowitz
2002-09-05  1:04                           ` Michal Ludvig
2002-09-06 13:01                             ` Mark Kettenis
2002-09-09 20:35                               ` Andrew Cagney
  -- strict thread matches above, loose matches on Subject: below --
2002-04-22  8:15 Michal Ludvig
2002-04-22  8:45 ` Daniel Jacobowitz
2002-04-22  9:08   ` Michal Ludvig
2002-04-22 19:05     ` Andrew Cagney
2002-04-22 21:28     ` Daniel Jacobowitz
2002-04-23  6:22       ` Michal Ludvig
2002-04-23  7:32         ` Daniel Jacobowitz
2002-04-29  9:54   ` Pierre Muller
2002-04-29 10:11     ` Michal Ludvig
2002-04-29 10:17     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020828144901.GA21703@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=ac131313@ges.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mludvig@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox