From: Joel Brobecker <brobecker@gnat.com>
To: Jim Ingham <jingham@apple.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] breakpoints and function prologues...
Date: Mon, 22 Jul 2002 22:49:00 -0000 [thread overview]
Message-ID: <20020723015412.GA7231@gnat.com> (raw)
In-Reply-To: <1E541B00-9DDA-11D6-924E-00039379E320@>
Jim,
> I solved the problem a little differently, however. The fact is that
> decode_line_1 takes a funfirstline argument, which is supposed to tell
> it whether to move the breakpoint past the prologue. But it doesn't
> look at this argument in the case of setting a file:line breakpoint.
> So I just made it do that. I like this solution, because it unifies in
> concept the breakpoint moving done for function symbols and for
> file:line symbols (though as you see, the actual motion is handled by
> different pieces of code.)
>
> I attached that patch below.
Thanks for your feedback.
I must say I really prefer your patch over mine. I hope this patch will
be approved for inclusion.
--
Joel
next prev parent reply other threads:[~2002-07-23 1:54 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1027384602.26926.ezmlm@sources.redhat.com>
2002-07-22 18:54 ` Jim Ingham
2002-07-22 22:49 ` Joel Brobecker [this message]
[not found] <1030059293.13128.ezmlm@sources.redhat.com>
2002-08-23 10:50 ` Jim Ingham
2002-08-23 11:34 ` Andrew Cagney
2002-08-24 18:31 ` Jim Ingham
2002-08-25 7:45 ` Andrew Cagney
2002-08-25 8:21 ` Daniel Jacobowitz
2002-08-25 15:24 ` Jim Ingham
2002-08-23 11:45 ` Michael Snyder
2002-08-23 11:48 ` Daniel Jacobowitz
[not found] <1029446396.15888.ezmlm@sources.redhat.com>
2002-08-15 15:26 ` Jim Ingham
2002-08-15 18:05 ` Andrew Cagney
2002-08-15 19:11 ` Joel Brobecker
2002-08-16 10:02 ` Jim Blandy
2002-08-16 10:17 ` Joel Brobecker
2002-08-15 19:18 ` Daniel Jacobowitz
2002-08-16 9:34 ` Jim Blandy
2002-08-16 11:34 ` Jim Ingham
2002-08-22 15:38 ` Michael Snyder
2002-08-22 15:56 ` Andrew Cagney
2002-08-22 16:34 ` Michael Snyder
[not found] <1028439120.16228.ezmlm@sources.redhat.com>
2002-08-06 13:37 ` Jim Ingham
2002-08-14 22:57 ` Andrew Cagney
2002-08-15 6:53 ` Daniel Jacobowitz
2002-08-22 15:33 ` Michael Snyder
2002-08-22 16:19 ` Joel Brobecker
2002-08-23 11:27 ` Daniel Jacobowitz
2002-07-22 17:36 Joel Brobecker
2002-07-23 16:53 ` Jim Blandy
2002-07-26 6:12 ` Joel Brobecker
2002-07-29 13:34 ` Daniel Jacobowitz
2002-07-29 23:57 ` Jim Blandy
2002-07-30 20:18 ` Joel Brobecker
2002-07-31 13:55 ` Jim Blandy
2002-08-01 15:44 ` Michael Snyder
2002-08-02 23:48 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020723015412.GA7231@gnat.com \
--to=brobecker@gnat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jingham@apple.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox