From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2121 invoked by alias); 23 Jul 2002 01:54:17 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1903 invoked from network); 23 Jul 2002 01:54:13 -0000 Received: from unknown (HELO takamaka.act-europe.fr) (142.179.108.108) by sources.redhat.com with SMTP; 23 Jul 2002 01:54:13 -0000 Received: by takamaka.act-europe.fr (Postfix, from userid 507) id 059E4D2CBD; Mon, 22 Jul 2002 18:54:12 -0700 (PDT) Date: Mon, 22 Jul 2002 22:49:00 -0000 From: Joel Brobecker To: Jim Ingham Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] breakpoints and function prologues... Message-ID: <20020723015412.GA7231@gnat.com> References: <1027384602.26926.ezmlm@sources.redhat.com> <1E541B00-9DDA-11D6-924E-00039379E320@> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1E541B00-9DDA-11D6-924E-00039379E320@> User-Agent: Mutt/1.4i X-SW-Source: 2002-07/txt/msg00453.txt.bz2 Jim, > I solved the problem a little differently, however. The fact is that > decode_line_1 takes a funfirstline argument, which is supposed to tell > it whether to move the breakpoint past the prologue. But it doesn't > look at this argument in the case of setting a file:line breakpoint. > So I just made it do that. I like this solution, because it unifies in > concept the breakpoint moving done for function symbols and for > file:line symbols (though as you see, the actual motion is handled by > different pieces of code.) > > I attached that patch below. Thanks for your feedback. I must say I really prefer your patch over mine. I hope this patch will be approved for inclusion. -- Joel