Re: Include param.h on FreeBSD/i386

[Daniel Jacobowitz <drow@mvista.com>]

On Sun, Jun 30, 2002 at 12:33:46PM -0700, David O'Brien wrote:
> On Sun, Jun 30, 2002 at 03:04:36PM -0400, Daniel Jacobowitz wrote:
> > > > > 2002-06-28  David O'Brien  <obrien@FreeBSD.org>
> > > > > 
> > > > > 	* config/i386/nm-fbsd.h: Include <sys/param.h>.
> > > > > 	* config/i386/tm-fbsd.h: Likewise.
> > > > 
> > > > Hi David.  Can you tell me why this is needed?
> > > 
> > > Some code I added to GDB 5.2 in the FreeBSD source tree needs it.  That
> > > code isn't ready to submit back yet.  Since the include is benign but I
> > > wanted to reduce the diffs where easy.
> ..snip..
> > Including system headers from the tm file is always pretty dodgy - what
> > do you need it for?  How does that include affect cross-debuggers?
> 
> I needed the __FreeBSD_version symbol and a few of the headers param.h
> includes.  For building a cross-debugger (cross-arch, not cross-OS) w/in
> the FreeBSD source tree this is still needed (and works).
> 
> As I mentioned the commit was to reduce changes I have to make in he
> FreeBSD tree.  I didn't think a benign include in a FreeBSD-specific
> header would raise an eyebrow.  :-)

Well, if you're going to use such a symbol please comment explicitly
why; it'll be a stumbling block for someone trying to build a cross-os
debugger.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer