From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1994 invoked by alias); 30 Jun 2002 19:46:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1971 invoked from network); 30 Jun 2002 19:45:54 -0000 Received: from unknown (HELO crack.them.org) (65.125.64.184) by sources.redhat.com with SMTP; 30 Jun 2002 19:45:54 -0000 Received: from gruel-2-149.ppp.andrew.cmu.edu ([128.2.2.149] helo=nevyn.them.org) by crack.them.org with asmtp (Exim 3.12 #1 (Debian)) id 17Okde-0003Ep-00; Sun, 30 Jun 2002 14:45:38 -0500 Received: from drow by nevyn.them.org with local (Exim 3.35 #1 (Debian)) id 17Okdd-0001OE-00; Sun, 30 Jun 2002 15:45:37 -0400 Date: Sun, 30 Jun 2002 12:46:00 -0000 From: Daniel Jacobowitz To: David O'Brien Cc: Mark Kettenis , gdb-patches@sources.redhat.com Subject: Re: Include param.h on FreeBSD/i386 Message-ID: <20020630194537.GA5262@nevyn.them.org> Mail-Followup-To: David O'Brien , Mark Kettenis , gdb-patches@sources.redhat.com References: <20020628131544.A53773@dragon.nuxi.com> <86k7og24w7.fsf@elgar.kettenis.dyndns.org> <20020630120003.B70260@dragon.nuxi.com> <20020630190436.GA4210@nevyn.them.org> <20020630123346.B71518@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020630123346.B71518@dragon.nuxi.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2002-06/txt/msg00590.txt.bz2 On Sun, Jun 30, 2002 at 12:33:46PM -0700, David O'Brien wrote: > On Sun, Jun 30, 2002 at 03:04:36PM -0400, Daniel Jacobowitz wrote: > > > > > 2002-06-28 David O'Brien > > > > > > > > > > * config/i386/nm-fbsd.h: Include . > > > > > * config/i386/tm-fbsd.h: Likewise. > > > > > > > > Hi David. Can you tell me why this is needed? > > > > > > Some code I added to GDB 5.2 in the FreeBSD source tree needs it. That > > > code isn't ready to submit back yet. Since the include is benign but I > > > wanted to reduce the diffs where easy. > ..snip.. > > Including system headers from the tm file is always pretty dodgy - what > > do you need it for? How does that include affect cross-debuggers? > > I needed the __FreeBSD_version symbol and a few of the headers param.h > includes. For building a cross-debugger (cross-arch, not cross-OS) w/in > the FreeBSD source tree this is still needed (and works). > > As I mentioned the commit was to reduce changes I have to make in he > FreeBSD tree. I didn't think a benign include in a FreeBSD-specific > header would raise an eyebrow. :-) Well, if you're going to use such a symbol please comment explicitly why; it'll be a stumbling block for someone trying to build a cross-os debugger. -- Daniel Jacobowitz Carnegie Mellon University MontaVista Software Debian GNU/Linux Developer