From: Daniel Jacobowitz <drow@mvista.com>
To: David O'Brien <obrien@FreeBSD.org>
Cc: Mark Kettenis <kettenis@chello.nl>, gdb-patches@sources.redhat.com
Subject: Re: Include param.h on FreeBSD/i386
Date: Sun, 30 Jun 2002 12:05:00 -0000 [thread overview]
Message-ID: <20020630190436.GA4210@nevyn.them.org> (raw)
In-Reply-To: <20020630120003.B70260@dragon.nuxi.com>
On Sun, Jun 30, 2002 at 12:00:03PM -0700, David O'Brien wrote:
> On Sun, Jun 30, 2002 at 04:54:48PM +0200, Mark Kettenis wrote:
> > "David O'Brien" <obrien@FreeBSD.org> writes:
> >
> > > I applied this patch to both mainline and 5.2_branch:
> > >
> > > 2002-06-28 David O'Brien <obrien@FreeBSD.org>
> > >
> > > * config/i386/nm-fbsd.h: Include <sys/param.h>.
> > > * config/i386/tm-fbsd.h: Likewise.
> >
> > Hi David. Can you tell me why this is needed?
>
> Some code I added to GDB 5.2 in the FreeBSD source tree needs it. That
> code isn't ready to submit back yet. Since the include is benign but I
> wanted to reduce the diffs where easy. I actually don't need it in
> nm-fbsd.h any more.
>
> > Including
> > <sys/param.h> from config/i386/tm-fbsd.h isn't right since this file
> > is going to be removed in the not so distant future,
>
> No problem, I'll reimpliment when that happens.
Including system headers from the tm file is always pretty dodgy - what
do you need it for? How does that include affect cross-debuggers?
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2002-06-30 19:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-28 13:15 David O'Brien
2002-06-30 7:54 ` Mark Kettenis
2002-06-30 12:00 ` David O'Brien
2002-06-30 12:05 ` Daniel Jacobowitz [this message]
2002-06-30 12:33 ` David O'Brien
2002-06-30 12:46 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020630190436.GA4210@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kettenis@chello.nl \
--cc=obrien@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox