From: Mark Kettenis <kettenis@chello.nl>
To: obrien@FreeBSD.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: Include param.h on FreeBSD/i386
Date: Sun, 30 Jun 2002 07:54:00 -0000 [thread overview]
Message-ID: <86k7og24w7.fsf@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: "David O'Brien"'s message of "Fri, 28 Jun 2002 13:15:44 -0700"
"David O'Brien" <obrien@FreeBSD.org> writes:
> I applied this patch to both mainline and 5.2_branch:
>
> 2002-06-28 David O'Brien <obrien@FreeBSD.org>
>
> * config/i386/nm-fbsd.h: Include <sys/param.h>.
> * config/i386/tm-fbsd.h: Likewise.
Hi David. Can you tell me why this is needed? Including
<sys/param.h> from config/i386/tm-fbsd.h isn't right since this file
is going to be removed in the not so distant future, and I have my
doubts about the change to config/i386/nm-fbsd.h too. If there is GDB
code that needs <sys/param.h> we should probably add it to the
appropriate files, not to the global nm.h.
Mark
next prev parent reply other threads:[~2002-06-30 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-28 13:15 David O'Brien
2002-06-30 7:54 ` Mark Kettenis [this message]
2002-06-30 12:00 ` David O'Brien
2002-06-30 12:05 ` Daniel Jacobowitz
2002-06-30 12:33 ` David O'Brien
2002-06-30 12:46 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86k7og24w7.fsf@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=obrien@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox