Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Michael Elizabeth Chastain]

I'm allergic to removing information from ChangeLogs, but I feel
comfortable adding a duplicate entry to gdb.mi/ChangeLog.  I don't
think a future historian would get too confused by that.

So that's what I'll do.  And in the future, I'll remember that
gdb.mi/ChangeLog exists, and use it (it looks like it's still active).

If only that were the worst problem gdb had.

Michael C

Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Michael Elizabeth Chastain]

Commited to gdb_5_2-branch.  I already committed to this to mainline.

Errr, in mainline, I added to the wrong ChangeLog.  I added to
gdb/testsuite/ChangeLog instead of gdb/testsuite/gdb.mi/ChangeLog.
Should I fix up the ChangeLog's in mainline, or add an entry
to gdb/testsuite/gdb.mi/ChangeLog, or leave them alone?

Michael C

2002-03-04  Michael Chastain  <mec@shout.net>

	* mi-var-cmd.exp: In test "create local variable func",
	accommodate gcc v3 function signature.
	* mi0-var-cmd-exp: Ditto.

Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Daniel Jacobowitz]

On Sat, Mar 09, 2002 at 11:03:56AM -0600, Michael Elizabeth Chastain wrote:
> Commited to gdb_5_2-branch.  I already committed to this to mainline.
> 
> Errr, in mainline, I added to the wrong ChangeLog.  I added to
> gdb/testsuite/ChangeLog instead of gdb/testsuite/gdb.mi/ChangeLog.
> Should I fix up the ChangeLog's in mainline, or add an entry
> to gdb/testsuite/gdb.mi/ChangeLog, or leave them alone?

Actually, I believe that gdb.mi/ChangeLog is obsolete.

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Andrew Cagney]

> On Sat, Mar 09, 2002 at 11:03:56AM -0600, Michael Elizabeth Chastain wrote:
> 
>> Commited to gdb_5_2-branch.  I already committed to this to mainline.

>> Errr, in mainline, I added to the wrong ChangeLog.  I added to
>> gdb/testsuite/ChangeLog instead of gdb/testsuite/gdb.mi/ChangeLog.
>> Should I fix up the ChangeLog's in mainline, or add an entry
>> to gdb/testsuite/gdb.mi/ChangeLog, or leave them alone?

I'd tweak it (just don't tell me :-).

> 
> Actually, I believe that gdb.mi/ChangeLog is obsolete.

? I still use it and I see a few others do.

Andrew

Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Daniel Jacobowitz]

On Sat, Mar 09, 2002 at 03:04:20PM -0500, Andrew Cagney wrote:
> >On Sat, Mar 09, 2002 at 11:03:56AM -0600, Michael Elizabeth Chastain wrote:
> >
> >>Commited to gdb_5_2-branch.  I already committed to this to mainline.
> 
> >>Errr, in mainline, I added to the wrong ChangeLog.  I added to
> >>gdb/testsuite/ChangeLog instead of gdb/testsuite/gdb.mi/ChangeLog.
> >>Should I fix up the ChangeLog's in mainline, or add an entry
> >>to gdb/testsuite/gdb.mi/ChangeLog, or leave them alone?
> 
> I'd tweak it (just don't tell me :-).
> 
> >
> >Actually, I believe that gdb.mi/ChangeLog is obsolete.
> 
> ? I still use it and I see a few others do.

Last time I checked, which was some time ago, I got the impression you
were using the one in the toplevel testsuite/ dir instead.  We both
seem to have been a little inconsistent, me especially... which way
would you prefer it?

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Michael Elizabeth Chastain]

Committed to mainline.

In a few days I will also apply this to the 5.2 branch.

Michael C

===

2002-03-04  Michael Chastain  <mec@shout.net>

	* gdb.mi/mi-var-cmd.exp: In test "create local variable func",
	accommodate gcc v3 function signature.
	* gdb.mi/mi0-var-cmd-exp: Ditto.

[PATCH] mi-var-cmd.exp, mi0-var-cmd.exp: accommodate gcc v3

[Michael Elizabeth Chastain]

Here is a small patch about v3 function signatures in gdb.mi/mi-var-cmd.exp
and gdb.mi/mi0-var-cmd.exp.  Here's what gdb.log looks like right now:

  # gcc 3.0.4, -gstabs+
  -var-create func * func^M
  ^done,name="func",numchild="0",type="void (*)()"^M
  (gdb) ^M
  PASS: gdb.mi/mi-var-cmd.exp: create local variable func

  # gcc 3.0.4, -gdwarf-2
  -var-create func * func^M
  ^done,name="func",numchild="0",type="void (*)(void)"^M
  (gdb) ^M
  FAIL: gdb.mi/mi-var-cmd.exp: create local variable func

I just make the tests accept both forms.

I tested this with my usual testbed:

  target:   native
  host:     i686-pc-linux-gnu%rh-7.2
  gdb:      HEAD%20020302
  gcc:      2.95.3, vendor, 3.0.4, gcc-3_1-branch%20020302, HEAD%20020302
  glibc:    vendor
  goption:  -gdwarf-2, -gstabs+

I'm keen to fix this because it shows up as a regression versus gdb 5.1.1.
I believe this is an obvious fix, and I'm going to go ahead and apply it to
mainline.  In a few days I will also apply it to the 5.2 branch.

Michael C

===

2002-03-04  Michael Chastain  <mec@shout.net>

	* gdb.mi/mi-var-cmd.exp: In test "create local variable func",
	accommodate gcc v3 function signature.
	* gdb.mi/mi0-var-cmd-exp: Ditto.

% cd /berman/fsf/_today_/source/gdb/HEAD/gdb/testsuite/gdb.mi
% cvs -q diff -c
Index: mi-var-cmd.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi-var-cmd.exp,v
retrieving revision 1.8
diff -c -r1.8 mi-var-cmd.exp
*** mi-var-cmd.exp	2001/11/11 20:11:03	1.8
--- mi-var-cmd.exp	2002/03/05 18:39:18
***************
*** 1,4 ****
! #   Copyright (C) 1999 2000 Cygnus Solutions
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! #   Copyright (C) 1999, 2000, 2002 Cygnus Solutions
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
***************
*** 136,142 ****
  	"create local variable lpsimple"
  
  mi_gdb_test "-var-create func * func" \
! 	"\\^done,name=\"func\",numchild=\"0\",type=\"void \\(\\*\\)\\(\\)\"" \
  	"create local variable func"
  
  # Test: c_variable-1.5
--- 136,142 ----
  	"create local variable lpsimple"
  
  mi_gdb_test "-var-create func * func" \
! 	"\\^done,name=\"func\",numchild=\"0\",type=\"void \\(\\*\\)\\((void|)\\)\"" \
  	"create local variable func"
  
  # Test: c_variable-1.5
Index: mi0-var-cmd.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.mi/mi0-var-cmd.exp,v
retrieving revision 1.6
diff -c -r1.6 mi0-var-cmd.exp
*** mi0-var-cmd.exp	2001/11/11 20:11:03	1.6
--- mi0-var-cmd.exp	2002/03/05 18:39:19
***************
*** 1,4 ****
! #   Copyright (C) 1999 2000 Cygnus Solutions
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! #   Copyright (C) 1999, 2000, 2002 Cygnus Solutions
  #
  # This Program Is Free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
***************
*** 136,142 ****
  	"create local variable lpsimple"
  
  mi_gdb_test "-var-create func * func" \
! 	"\\^done,name=\"func\",numchild=\"0\",type=\"void \\(\\*\\)\\(\\)\"" \
  	"create local variable func"
  
  # Test: c_variable-1.5
--- 136,142 ----
  	"create local variable lpsimple"
  
  mi_gdb_test "-var-create func * func" \
! 	"\\^done,name=\"func\",numchild=\"0\",type=\"void \\(\\*\\)\\((void|)\\)\"" \
  	"create local variable func"
  
  # Test: c_variable-1.5