Re: PATCH: obvious: testsuite/gdb.base/funcargs.c: fix declaration

Re: PATCH: obvious: testsuite/gdb.base/funcargs.c: fix declaration

[Michael Elizabeth Chastain]

Committed.

Michael C

===

2002-02-10  Michael Chastain  <mec@shout.net>

	* gdb.base/funcargs.c (localvars_after_alloca): Fix return type.
	(call_after_alloca): Ditto.

PATCH: obvious: testsuite/gdb.base/funcargs.c: fix declaration

[Michael Elizabeth Chastain]

These declarations have been broken for a long time.  The prototyped
declarations were already correct; the non-prototyped declarations
were just plain wrong.

Gcc HEAD just started complaining this week, causing a bunch of
ERRORs and WRANINGs.

Tested on native i686-pc-linux-gnulibc2.2-rh7.2 with gcc 3.0.2 and gcc HEAD.

This fixes half of PR gdb/348.

I'm committing this as obvious.

Michael Elizabeth Chastain
<mailto:mec@shout.net>
"love without fear"

===

2002-02-10  Michael Chastain  <mec@shout.net>

	* gdb.base/funcargs.c (localvars_after_alloca): Fix return type.
	(call_after_alloca): Ditto.

Index: testsuite/gdb.base/funcargs.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/funcargs.c,v
retrieving revision 1.1.1.2
diff -c -3 -p -r1.1.1.2 funcargs.c
*** funcargs.c	1999/06/28 16:03:13	1.1.1.2
--- funcargs.c	2002/02/11 04:40:31
*************** void test_struct_args ()
*** 634,640 ****
  #ifdef PROTOTYPES
  void localvars_after_alloca (char c, short s, int i, long l)
  #else
! int
  localvars_after_alloca (c, s, i, l)
       char c;
       short s;
--- 634,640 ----
  #ifdef PROTOTYPES
  void localvars_after_alloca (char c, short s, int i, long l)
  #else
! void
  localvars_after_alloca (c, s, i, l)
       char c;
       short s;
*************** char c; int i; short s; long l; unsigned
*** 671,677 ****
  #ifdef PROTOTYPES
  void call_after_alloca (char c, short s, int i, long l)
  #else
! int
  call_after_alloca (c, s, i, l)
       char c;
       short s;
--- 671,677 ----
  #ifdef PROTOTYPES
  void call_after_alloca (char c, short s, int i, long l)
  #else
! void
  call_after_alloca (c, s, i, l)
       char c;
       short s;

Re: PATCH: obvious: testsuite/gdb.base/funcargs.c: fix declaration

[Fernando Nasser]

Thanks Michael.

Fernando


Michael Elizabeth Chastain wrote:
> 
> These declarations have been broken for a long time.  The prototyped
> declarations were already correct; the non-prototyped declarations
> were just plain wrong.
> 
> Gcc HEAD just started complaining this week, causing a bunch of
> ERRORs and WRANINGs.
> 
> Tested on native i686-pc-linux-gnulibc2.2-rh7.2 with gcc 3.0.2 and gcc HEAD.
> 
> This fixes half of PR gdb/348.
> 
> I'm committing this as obvious.
> 
> Michael Elizabeth Chastain
> <mailto:mec@shout.net>
> "love without fear"
> 
> ===
> 
> 2002-02-10  Michael Chastain  <mec@shout.net>
> 
>         * gdb.base/funcargs.c (localvars_after_alloca): Fix return type.
>         (call_after_alloca): Ditto.
> 
> Index: testsuite/gdb.base/funcargs.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/funcargs.c,v
> retrieving revision 1.1.1.2
> diff -c -3 -p -r1.1.1.2 funcargs.c
> *** funcargs.c  1999/06/28 16:03:13     1.1.1.2
> --- funcargs.c  2002/02/11 04:40:31
> *************** void test_struct_args ()
> *** 634,640 ****
>   #ifdef PROTOTYPES
>   void localvars_after_alloca (char c, short s, int i, long l)
>   #else
> ! int
>   localvars_after_alloca (c, s, i, l)
>        char c;
>        short s;
> --- 634,640 ----
>   #ifdef PROTOTYPES
>   void localvars_after_alloca (char c, short s, int i, long l)
>   #else
> ! void
>   localvars_after_alloca (c, s, i, l)
>        char c;
>        short s;
> *************** char c; int i; short s; long l; unsigned
> *** 671,677 ****
>   #ifdef PROTOTYPES
>   void call_after_alloca (char c, short s, int i, long l)
>   #else
> ! int
>   call_after_alloca (c, s, i, l)
>        char c;
>        short s;
> --- 671,677 ----
>   #ifdef PROTOTYPES
>   void call_after_alloca (char c, short s, int i, long l)
>   #else
> ! void
>   call_after_alloca (c, s, i, l)
>        char c;
>        short s;

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9