From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13113 invoked by alias); 11 Feb 2002 15:50:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13060 invoked from network); 11 Feb 2002 15:50:33 -0000 Received: from unknown (HELO cygnus.com) (205.180.230.5) by sources.redhat.com with SMTP; 11 Feb 2002 15:50:33 -0000 Received: from redhat.com (rtl.cygnus.com [205.180.230.21]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id HAA06472; Mon, 11 Feb 2002 07:50:16 -0800 (PST) Message-ID: <3C67E81C.AD7B05AF@redhat.com> Date: Mon, 11 Feb 2002 07:50:00 -0000 From: Fernando Nasser Organization: Red Hat Canada X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.9-21 i686) X-Accept-Language: en MIME-Version: 1.0 To: Michael Elizabeth Chastain CC: gdb-patches@sources.redhat.com Subject: Re: PATCH: obvious: testsuite/gdb.base/funcargs.c: fix declaration References: <200202110442.g1B4glt19667@duracef.shout.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-02/txt/msg00323.txt.bz2 Thanks Michael. Fernando Michael Elizabeth Chastain wrote: > > These declarations have been broken for a long time. The prototyped > declarations were already correct; the non-prototyped declarations > were just plain wrong. > > Gcc HEAD just started complaining this week, causing a bunch of > ERRORs and WRANINGs. > > Tested on native i686-pc-linux-gnulibc2.2-rh7.2 with gcc 3.0.2 and gcc HEAD. > > This fixes half of PR gdb/348. > > I'm committing this as obvious. > > Michael Elizabeth Chastain > > "love without fear" > > === > > 2002-02-10 Michael Chastain > > * gdb.base/funcargs.c (localvars_after_alloca): Fix return type. > (call_after_alloca): Ditto. > > Index: testsuite/gdb.base/funcargs.c > =================================================================== > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/funcargs.c,v > retrieving revision 1.1.1.2 > diff -c -3 -p -r1.1.1.2 funcargs.c > *** funcargs.c 1999/06/28 16:03:13 1.1.1.2 > --- funcargs.c 2002/02/11 04:40:31 > *************** void test_struct_args () > *** 634,640 **** > #ifdef PROTOTYPES > void localvars_after_alloca (char c, short s, int i, long l) > #else > ! int > localvars_after_alloca (c, s, i, l) > char c; > short s; > --- 634,640 ---- > #ifdef PROTOTYPES > void localvars_after_alloca (char c, short s, int i, long l) > #else > ! void > localvars_after_alloca (c, s, i, l) > char c; > short s; > *************** char c; int i; short s; long l; unsigned > *** 671,677 **** > #ifdef PROTOTYPES > void call_after_alloca (char c, short s, int i, long l) > #else > ! int > call_after_alloca (c, s, i, l) > char c; > short s; > --- 671,677 ---- > #ifdef PROTOTYPES > void call_after_alloca (char c, short s, int i, long l) > #else > ! void > call_after_alloca (c, s, i, l) > char c; > short s; -- Fernando Nasser Red Hat Canada Ltd. E-Mail: fnasser@redhat.com 2323 Yonge Street, Suite #300 Toronto, Ontario M4P 2C9