Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fernando Nasser <fnasser@redhat.com>
To: Michael Elizabeth Chastain <mec@shout.net>
Cc: gdb-patches@sources.redhat.com
Subject: Re: PATCH: obvious: testsuite/gdb.base/funcargs.c: fix declaration
Date: Mon, 11 Feb 2002 07:50:00 -0000	[thread overview]
Message-ID: <3C67E81C.AD7B05AF@redhat.com> (raw)
In-Reply-To: <200202110442.g1B4glt19667@duracef.shout.net>

Thanks Michael.

Fernando


Michael Elizabeth Chastain wrote:
> 
> These declarations have been broken for a long time.  The prototyped
> declarations were already correct; the non-prototyped declarations
> were just plain wrong.
> 
> Gcc HEAD just started complaining this week, causing a bunch of
> ERRORs and WRANINGs.
> 
> Tested on native i686-pc-linux-gnulibc2.2-rh7.2 with gcc 3.0.2 and gcc HEAD.
> 
> This fixes half of PR gdb/348.
> 
> I'm committing this as obvious.
> 
> Michael Elizabeth Chastain
> <mailto:mec@shout.net>
> "love without fear"
> 
> ===
> 
> 2002-02-10  Michael Chastain  <mec@shout.net>
> 
>         * gdb.base/funcargs.c (localvars_after_alloca): Fix return type.
>         (call_after_alloca): Ditto.
> 
> Index: testsuite/gdb.base/funcargs.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/funcargs.c,v
> retrieving revision 1.1.1.2
> diff -c -3 -p -r1.1.1.2 funcargs.c
> *** funcargs.c  1999/06/28 16:03:13     1.1.1.2
> --- funcargs.c  2002/02/11 04:40:31
> *************** void test_struct_args ()
> *** 634,640 ****
>   #ifdef PROTOTYPES
>   void localvars_after_alloca (char c, short s, int i, long l)
>   #else
> ! int
>   localvars_after_alloca (c, s, i, l)
>        char c;
>        short s;
> --- 634,640 ----
>   #ifdef PROTOTYPES
>   void localvars_after_alloca (char c, short s, int i, long l)
>   #else
> ! void
>   localvars_after_alloca (c, s, i, l)
>        char c;
>        short s;
> *************** char c; int i; short s; long l; unsigned
> *** 671,677 ****
>   #ifdef PROTOTYPES
>   void call_after_alloca (char c, short s, int i, long l)
>   #else
> ! int
>   call_after_alloca (c, s, i, l)
>        char c;
>        short s;
> --- 671,677 ----
>   #ifdef PROTOTYPES
>   void call_after_alloca (char c, short s, int i, long l)
>   #else
> ! void
>   call_after_alloca (c, s, i, l)
>        char c;
>        short s;

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario   M4P 2C9


  reply	other threads:[~2002-02-11 15:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-10 20:42 Michael Elizabeth Chastain
2002-02-11  7:50 ` Fernando Nasser [this message]
2002-02-10 20:48 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C67E81C.AD7B05AF@redhat.com \
    --to=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec@shout.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox