RFA: another tweak to an init_types() call

RFA: another tweak to an init_types() call

[Fred Fish]

The build_gdbtypes() function in gdbtypes.c has another instance of
where init_type() is called with empty flag bits and then a flag bit
is set on the newly created type.  This patch fixes it, like in the
similar c-lang.c patch approved and applied yesterday.

-Fred


2001-12-09  Fred Fish  <fnf@redhat.com>

	* gdbtypes.c (build_gdbtypes): For builtin_type_char, pass
	TYPE_FLAG_NOSIGN to init_type() rather than setting it after the
	type is created.

Index: gdbtypes.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtypes.c,v
retrieving revision 1.29
diff -u -p -r1.29 gdbtypes.c
--- gdbtypes.c	2001/12/07 22:11:51	1.29
+++ gdbtypes.c	2001/12/09 18:07:25
@@ -2939,9 +2937,8 @@ build_gdbtypes (void)
 	       "void", (struct objfile *) NULL);
   builtin_type_char =
     init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
-	       0,
+	       TYPE_FLAG_NOSIGN,
 	       "char", (struct objfile *) NULL);
-  TYPE_FLAGS (builtin_type_char) |= TYPE_FLAG_NOSIGN;
   builtin_type_true_char =
     init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
 	       0,

Re: RFA: another tweak to an init_types() call

[Jim Blandy]

Approved.

Fred Fish <fnf@ns1.ninemoons.com> writes:

> 
> The build_gdbtypes() function in gdbtypes.c has another instance of
> where init_type() is called with empty flag bits and then a flag bit
> is set on the newly created type.  This patch fixes it, like in the
> similar c-lang.c patch approved and applied yesterday.
> 
> -Fred
> 
> 
> 2001-12-09  Fred Fish  <fnf@redhat.com>
> 
> 	* gdbtypes.c (build_gdbtypes): For builtin_type_char, pass
> 	TYPE_FLAG_NOSIGN to init_type() rather than setting it after the
> 	type is created.
> 
> Index: gdbtypes.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtypes.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 gdbtypes.c
> --- gdbtypes.c	2001/12/07 22:11:51	1.29
> +++ gdbtypes.c	2001/12/09 18:07:25
> @@ -2939,9 +2937,8 @@ build_gdbtypes (void)
>  	       "void", (struct objfile *) NULL);
>    builtin_type_char =
>      init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
> -	       0,
> +	       TYPE_FLAG_NOSIGN,
>  	       "char", (struct objfile *) NULL);
> -  TYPE_FLAGS (builtin_type_char) |= TYPE_FLAG_NOSIGN;
>    builtin_type_true_char =
>      init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
>  	       0,
>