From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13740 invoked by alias); 9 Dec 2001 18:13:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13606 invoked from network); 9 Dec 2001 18:11:42 -0000 Received: from unknown (HELO fishpond.ninemoons.com) (64.232.230.104) by sources.redhat.com with SMTP; 9 Dec 2001 18:11:42 -0000 Received: (from fnf@localhost) by fishpond.ninemoons.com (8.11.6/8.11.6) id fB9I6Kc02506; Sun, 9 Dec 2001 11:06:20 -0700 From: Fred Fish Message-Id: <200112091806.fB9I6Kc02506@fishpond.ninemoons.com> Subject: RFA: another tweak to an init_types() call To: gdb-patches@sources.redhat.com Date: Sun, 09 Dec 2001 10:13:00 -0000 Cc: fnf@redhat.com Reply-To: fnf@redhat.com X-Mailer: ELM [version 2.5 PL6] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2001-12/txt/msg00249.txt.bz2 The build_gdbtypes() function in gdbtypes.c has another instance of where init_type() is called with empty flag bits and then a flag bit is set on the newly created type. This patch fixes it, like in the similar c-lang.c patch approved and applied yesterday. -Fred 2001-12-09 Fred Fish * gdbtypes.c (build_gdbtypes): For builtin_type_char, pass TYPE_FLAG_NOSIGN to init_type() rather than setting it after the type is created. Index: gdbtypes.c =================================================================== RCS file: /cvs/src/src/gdb/gdbtypes.c,v retrieving revision 1.29 diff -u -p -r1.29 gdbtypes.c --- gdbtypes.c 2001/12/07 22:11:51 1.29 +++ gdbtypes.c 2001/12/09 18:07:25 @@ -2939,9 +2937,8 @@ build_gdbtypes (void) "void", (struct objfile *) NULL); builtin_type_char = init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT, - 0, + TYPE_FLAG_NOSIGN, "char", (struct objfile *) NULL); - TYPE_FLAGS (builtin_type_char) |= TYPE_FLAG_NOSIGN; builtin_type_true_char = init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT, 0,