From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-11195-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 1168 invoked by alias); 10 Dec 2001 03:07:30 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 1127 invoked from network); 10 Dec 2001 03:07:29 -0000
Received: from unknown (HELO zwingli.cygnus.com) (208.245.165.35)
  by sources.redhat.com with SMTP; 10 Dec 2001 03:07:29 -0000
Received: by zwingli.cygnus.com (Postfix, from userid 442)
	id 519565E9D8; Sun,  9 Dec 2001 22:08:47 -0500 (EST)
To: fnf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: RFA: another tweak to an init_types() call
References: <200112091806.fB9I6Kc02506@fishpond.ninemoons.com>
From: Jim Blandy <jimb@zwingli.cygnus.com>
Date: Sun, 09 Dec 2001 19:07:00 -0000
In-Reply-To: Fred Fish's message of Sun, 9 Dec 2001 11:06:20 -0700 (MST)
Message-ID: <npd71n3h6o.fsf@zwingli.cygnus.com>
X-Mailer: Gnus v5.3/Emacs 19.34
X-SW-Source: 2001-12/txt/msg00262.txt.bz2


Approved.

Fred Fish <fnf@ns1.ninemoons.com> writes:

> 
> The build_gdbtypes() function in gdbtypes.c has another instance of
> where init_type() is called with empty flag bits and then a flag bit
> is set on the newly created type.  This patch fixes it, like in the
> similar c-lang.c patch approved and applied yesterday.
> 
> -Fred
> 
> 
> 2001-12-09  Fred Fish  <fnf@redhat.com>
> 
> 	* gdbtypes.c (build_gdbtypes): For builtin_type_char, pass
> 	TYPE_FLAG_NOSIGN to init_type() rather than setting it after the
> 	type is created.
> 
> Index: gdbtypes.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtypes.c,v
> retrieving revision 1.29
> diff -u -p -r1.29 gdbtypes.c
> --- gdbtypes.c	2001/12/07 22:11:51	1.29
> +++ gdbtypes.c	2001/12/09 18:07:25
> @@ -2939,9 +2937,8 @@ build_gdbtypes (void)
>  	       "void", (struct objfile *) NULL);
>    builtin_type_char =
>      init_type (TYPE_CODE_INT, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
> -	       0,
> +	       TYPE_FLAG_NOSIGN,
>  	       "char", (struct objfile *) NULL);
> -  TYPE_FLAGS (builtin_type_char) |= TYPE_FLAG_NOSIGN;
>    builtin_type_true_char =
>      init_type (TYPE_CODE_CHAR, TARGET_CHAR_BIT / TARGET_CHAR_BIT,
>  	       0,
>