* [RFA] Fix compilation failure in bfd/som.c under HPUX 11.00
@ 2001-09-27 7:07 Joel Brobecker
2001-09-27 11:32 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Joel Brobecker @ 2001-09-27 7:07 UTC (permalink / raw)
To: gdb-patches
There is a small error in this file. The type of the parameter current_offset in function som_write_symbol_strings () do not oatc between the declaration of the function (declared as unsigned long)
and its implementation (declared as file_ptr). Judjing from the rest of
the code, it should be "unsigned long".
So I suggest the following change. With the changes to hpux-thread.c
reported earlier, this is the only other change that I needed in order
to compile GDB on HPUX-11.00. For the same reasons, I did not have time
to test it, it also seems quite reasonable a change.
2001-09-27 J. Brobecker <brobecker@gnat.com>
* som.c (som_write_symbol_strings): Fix incorrect type of
current_offset to match the function definition. Fixes a build
failure on HPUX-11.00
<<
Index: som.c
===================================================================
RCS file: /cvs/src/src/bfd/som.c,v
retrieving revision 1.22
diff -c -3 -p -r1.22 som.c
*** som.c 2001/09/19 05:33:12 1.22
--- som.c 2001/09/27 13:58:18
*************** static boolean
*** 3155,3161 ****
som_write_symbol_strings (abfd, current_offset, syms, num_syms, string_sizep,
compilation_unit)
bfd *abfd;
! file_ptr current_offset;
asymbol **syms;
unsigned int num_syms;
unsigned int *string_sizep;
--- 3155,3161 ----
som_write_symbol_strings (abfd, current_offset, syms, num_syms, string_sizep,
compilation_unit)
bfd *abfd;
! unsigned long current_offset;
asymbol **syms;
unsigned int num_syms;
unsigned int *string_sizep;
>>
--
Joel
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFA] Fix compilation failure in bfd/som.c under HPUX 11.00
2001-09-27 7:07 [RFA] Fix compilation failure in bfd/som.c under HPUX 11.00 Joel Brobecker
@ 2001-09-27 11:32 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2001-09-27 11:32 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
> There is a small error in this file. The type of the parameter current_offset in function som_write_symbol_strings () do not oatc between the declaration of the function (declared as unsigned long)
> and its implementation (declared as file_ptr). Judjing from the rest of
> the code, it should be "unsigned long".
>
> So I suggest the following change. With the changes to hpux-thread.c
> reported earlier, this is the only other change that I needed in order
> to compile GDB on HPUX-11.00. For the same reasons, I did not have time
> to test it, it also seems quite reasonable a change.
>
> 2001-09-27 J. Brobecker <brobecker@gnat.com> * som.c (som_write_symbol_strings): Fix incorrect type of
> current_offset to match the function definition. Fixes a build
> failure on HPUX-11.00
>
>
Fine with me. Per Kevins comments on the other patch just tweek it and
it can too go in.
Build problems and bit rot like this are pretty obvious.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-09-27 11:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-27 7:07 [RFA] Fix compilation failure in bfd/som.c under HPUX 11.00 Joel Brobecker
2001-09-27 11:32 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox