From: Andrew Cagney <ac131313@cygnus.com>
To: Joel Brobecker <brobecker@act-europe.fr>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Fix compilation failure in bfd/som.c under HPUX 11.00
Date: Thu, 27 Sep 2001 11:32:00 -0000 [thread overview]
Message-ID: <3BB370B3.3020904@cygnus.com> (raw)
In-Reply-To: <20010927160703.G21075@act-europe.fr>
> There is a small error in this file. The type of the parameter current_offset in function som_write_symbol_strings () do not oatc between the declaration of the function (declared as unsigned long)
> and its implementation (declared as file_ptr). Judjing from the rest of
> the code, it should be "unsigned long".
>
> So I suggest the following change. With the changes to hpux-thread.c
> reported earlier, this is the only other change that I needed in order
> to compile GDB on HPUX-11.00. For the same reasons, I did not have time
> to test it, it also seems quite reasonable a change.
>
> 2001-09-27 J. Brobecker <brobecker@gnat.com> * som.c (som_write_symbol_strings): Fix incorrect type of
> current_offset to match the function definition. Fixes a build
> failure on HPUX-11.00
>
>
Fine with me. Per Kevins comments on the other patch just tweek it and
it can too go in.
Build problems and bit rot like this are pretty obvious.
Andrew
prev parent reply other threads:[~2001-09-27 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-27 7:07 Joel Brobecker
2001-09-27 11:32 ` Andrew Cagney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3BB370B3.3020904@cygnus.com \
--to=ac131313@cygnus.com \
--cc=brobecker@act-europe.fr \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox