From: Joel Brobecker <brobecker@act-europe.fr>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix compilation failure in bfd/som.c under HPUX 11.00
Date: Thu, 27 Sep 2001 07:07:00 -0000 [thread overview]
Message-ID: <20010927160703.G21075@act-europe.fr> (raw)
There is a small error in this file. The type of the parameter current_offset in function som_write_symbol_strings () do not oatc between the declaration of the function (declared as unsigned long)
and its implementation (declared as file_ptr). Judjing from the rest of
the code, it should be "unsigned long".
So I suggest the following change. With the changes to hpux-thread.c
reported earlier, this is the only other change that I needed in order
to compile GDB on HPUX-11.00. For the same reasons, I did not have time
to test it, it also seems quite reasonable a change.
2001-09-27 J. Brobecker <brobecker@gnat.com>
* som.c (som_write_symbol_strings): Fix incorrect type of
current_offset to match the function definition. Fixes a build
failure on HPUX-11.00
<<
Index: som.c
===================================================================
RCS file: /cvs/src/src/bfd/som.c,v
retrieving revision 1.22
diff -c -3 -p -r1.22 som.c
*** som.c 2001/09/19 05:33:12 1.22
--- som.c 2001/09/27 13:58:18
*************** static boolean
*** 3155,3161 ****
som_write_symbol_strings (abfd, current_offset, syms, num_syms, string_sizep,
compilation_unit)
bfd *abfd;
! file_ptr current_offset;
asymbol **syms;
unsigned int num_syms;
unsigned int *string_sizep;
--- 3155,3161 ----
som_write_symbol_strings (abfd, current_offset, syms, num_syms, string_sizep,
compilation_unit)
bfd *abfd;
! unsigned long current_offset;
asymbol **syms;
unsigned int num_syms;
unsigned int *string_sizep;
>>
--
Joel
next reply other threads:[~2001-09-27 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-27 7:07 Joel Brobecker [this message]
2001-09-27 11:32 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010927160703.G21075@act-europe.fr \
--to=brobecker@act-europe.fr \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox