Re: Fix m68k-linux build

Re: Fix m68k-linux build

[Andrew Cagney]

> I don't have the hardware to test this, but by (exact) analogy with all the
> other Linux ports, I'm pretty sure it's correct.  And yes, I intend to
> eliminate all these copies of fetch_core_registers in one fell swoop some
> day soon...


Most of the patch falls into the obvious category and can just go 
straight in.  As you note, there is no maintainer.

For the ChangeLog, could I suggest a form like:

YYYY-MM-DD <you>


	From Michael Fedrowitz  <michael.fedrowitz@informatik.uni-ulm.de>:

	* m68klinux-nat.c: Fix comment.
	(supply_gregset): Change argument to elf_gregset_t *.
	(supply_fpregset): Change argument to elf_fpregset_t *.


		From ....:
		change-log


it makes checking on changes much easier.

>  (fetch_core_registers): New function.


Separatly.
Could you please add a comment to the code explaining where the function 
was copied from (Or better bypass this step and rationalize those 
functions :-).

	Andrew

Re: Fix m68k-linux build

[Daniel Jacobowitz]

On Wed, Jul 11, 2001 at 02:25:23PM -0400, Andrew Cagney wrote:
> > I don't have the hardware to test this, but by (exact) analogy with all the
> > other Linux ports, I'm pretty sure it's correct.  And yes, I intend to
> > eliminate all these copies of fetch_core_registers in one fell swoop some
> > day soon...
> 
> 
> Most of the patch falls into the obvious category and can just go 
> straight in.  As you note, there is no maintainer.

Committed, commented, and I think I'm going to go ahead and make my new
core handling work today.

> Could you please add a comment to the code explaining where the function 
> was copied from (Or better bypass this step and rationalize those 
> functions :-).

Was already there, actually:
   (We can't use the generic version of this function in
   core-regset.c, because we need to use elf_gregset_t instead of
   gregset_t.)

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer