From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cagney To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com Subject: Re: Fix m68k-linux build Date: Wed, 11 Jul 2001 11:25:00 -0000 Message-id: <3B4C9A13.6070205@cygnus.com> References: <20010711110229.A21075@nevyn.them.org> X-SW-Source: 2001-07/msg00267.html > I don't have the hardware to test this, but by (exact) analogy with all the > other Linux ports, I'm pretty sure it's correct. And yes, I intend to > eliminate all these copies of fetch_core_registers in one fell swoop some > day soon... Most of the patch falls into the obvious category and can just go straight in. As you note, there is no maintainer. For the ChangeLog, could I suggest a form like: YYYY-MM-DD From Michael Fedrowitz : * m68klinux-nat.c: Fix comment. (supply_gregset): Change argument to elf_gregset_t *. (supply_fpregset): Change argument to elf_fpregset_t *. From ....: change-log it makes checking on changes much easier. > (fetch_core_registers): New function. Separatly. Could you please add a comment to the code explaining where the function was copied from (Or better bypass this step and rationalize those functions :-). Andrew