From: Andrew Cagney <ac131313@cygnus.com>
To: Daniel Jacobowitz <dmj+@andrew.cmu.edu>
Cc: gdb-patches@sources.redhat.com
Subject: Re: Fix m68k-linux build
Date: Wed, 11 Jul 2001 11:25:00 -0000 [thread overview]
Message-ID: <3B4C9A13.6070205@cygnus.com> (raw)
In-Reply-To: <20010711110229.A21075@nevyn.them.org>
> I don't have the hardware to test this, but by (exact) analogy with all the
> other Linux ports, I'm pretty sure it's correct. And yes, I intend to
> eliminate all these copies of fetch_core_registers in one fell swoop some
> day soon...
Most of the patch falls into the obvious category and can just go
straight in. As you note, there is no maintainer.
For the ChangeLog, could I suggest a form like:
YYYY-MM-DD <you>
From Michael Fedrowitz <michael.fedrowitz@informatik.uni-ulm.de>:
* m68klinux-nat.c: Fix comment.
(supply_gregset): Change argument to elf_gregset_t *.
(supply_fpregset): Change argument to elf_fpregset_t *.
From ....:
change-log
it makes checking on changes much easier.
> (fetch_core_registers): New function.
Separatly.
Could you please add a comment to the code explaining where the function
was copied from (Or better bypass this step and rationalize those
functions :-).
Andrew
next parent reply other threads:[~2001-07-11 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20010711110229.A21075@nevyn.them.org>
2001-07-11 11:25 ` Andrew Cagney [this message]
2001-07-11 11:39 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B4C9A13.6070205@cygnus.com \
--to=ac131313@cygnus.com \
--cc=dmj+@andrew.cmu.edu \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox