* [RFA] symtab.c (search_symbols) -- fix off by one error
@ 2001-02-19 12:59 David Taylor
2001-02-19 16:00 ` Elena Zannoni
0 siblings, 1 reply; 2+ messages in thread
From: David Taylor @ 2001-02-19 12:59 UTC (permalink / raw)
To: gdb-patches; +Cc: ezannoni
ChangeLog entry:
* symtab.c (search_symbols): Fix off by one error in test for
error.
Index: symtab.c
===================================================================
RCS file: /cvs/src/src/gdb/symtab.c,v
retrieving revision 1.28
diff -c -r1.28 symtab.c
*** symtab.c 2001/01/30 02:49:36 1.28
--- symtab.c 2001/02/19 20:55:43
***************
*** 2348,2354 ****
struct symbol_search *tail;
struct cleanup *old_chain = NULL;
! if (kind < LABEL_NAMESPACE)
error ("must search on specific namespace");
ourtype = types[(int) (kind - VARIABLES_NAMESPACE)];
--- 2348,2354 ----
struct symbol_search *tail;
struct cleanup *old_chain = NULL;
! if (kind < VARIABLES_NAMESPACE)
error ("must search on specific namespace");
ourtype = types[(int) (kind - VARIABLES_NAMESPACE)];
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [RFA] symtab.c (search_symbols) -- fix off by one error
2001-02-19 12:59 [RFA] symtab.c (search_symbols) -- fix off by one error David Taylor
@ 2001-02-19 16:00 ` Elena Zannoni
0 siblings, 0 replies; 2+ messages in thread
From: Elena Zannoni @ 2001-02-19 16:00 UTC (permalink / raw)
To: David Taylor; +Cc: gdb-patches, ezannoni
Background: I pinged David to check the status of this patch:
http://sources.redhat.com/ml/gdb-patches/2000-08/msg00290.html (which
occurred in my list of pending patches).
The patch had been committed but prompted for a second review of the
code, and the following patch was the result.
OK, this patch can be committed.
Thanks
Elena
David Taylor writes:
> ChangeLog entry:
>
> * symtab.c (search_symbols): Fix off by one error in test for
> error.
>
> Index: symtab.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/symtab.c,v
> retrieving revision 1.28
> diff -c -r1.28 symtab.c
> *** symtab.c 2001/01/30 02:49:36 1.28
> --- symtab.c 2001/02/19 20:55:43
> ***************
> *** 2348,2354 ****
> struct symbol_search *tail;
> struct cleanup *old_chain = NULL;
>
> ! if (kind < LABEL_NAMESPACE)
> error ("must search on specific namespace");
>
> ourtype = types[(int) (kind - VARIABLES_NAMESPACE)];
> --- 2348,2354 ----
> struct symbol_search *tail;
> struct cleanup *old_chain = NULL;
>
> ! if (kind < VARIABLES_NAMESPACE)
> error ("must search on specific namespace");
>
> ourtype = types[(int) (kind - VARIABLES_NAMESPACE)];
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-02-19 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-02-19 12:59 [RFA] symtab.c (search_symbols) -- fix off by one error David Taylor
2001-02-19 16:00 ` Elena Zannoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox