Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Elena Zannoni <ezannoni@cygnus.com>
To: David Taylor <taylor@cygnus.com>
Cc: gdb-patches@sources.redhat.com, ezannoni@cygnus.com
Subject: Re: [RFA] symtab.c (search_symbols) -- fix off by one error
Date: Mon, 19 Feb 2001 16:00:00 -0000	[thread overview]
Message-ID: <14993.45970.145792.634625@kwikemart.cygnus.com> (raw)
In-Reply-To: <200102192059.PAA18068@texas.cygnus.com>

Background: I pinged David to check the status of this patch:
http://sources.redhat.com/ml/gdb-patches/2000-08/msg00290.html (which
occurred in my list of pending patches).  

The patch had been committed but prompted for a second review of the
code, and the following patch was the result.

OK, this patch can be committed.

Thanks
Elena


David Taylor writes:
 > ChangeLog entry:
 > 
 > 	* symtab.c (search_symbols): Fix off by one error in test for
 > 	error.
 > 
 > Index: symtab.c
 > ===================================================================
 > RCS file: /cvs/src/src/gdb/symtab.c,v
 > retrieving revision 1.28
 > diff -c -r1.28 symtab.c
 > *** symtab.c    2001/01/30 02:49:36     1.28
 > --- symtab.c    2001/02/19 20:55:43
 > ***************
 > *** 2348,2354 ****
 >     struct symbol_search *tail;
 >     struct cleanup *old_chain = NULL;
 >   
 > !   if (kind < LABEL_NAMESPACE)
 >       error ("must search on specific namespace");
 >   
 >     ourtype = types[(int) (kind - VARIABLES_NAMESPACE)];
 > --- 2348,2354 ----
 >     struct symbol_search *tail;
 >     struct cleanup *old_chain = NULL;
 >   
 > !   if (kind < VARIABLES_NAMESPACE)
 >       error ("must search on specific namespace");
 >   
 >     ourtype = types[(int) (kind - VARIABLES_NAMESPACE)];
 > 


      reply	other threads:[~2001-02-19 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-02-19 12:59 David Taylor
2001-02-19 16:00 ` Elena Zannoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14993.45970.145792.634625@kwikemart.cygnus.com \
    --to=ezannoni@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=taylor@cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox